Project

General

Profile

Actions

Bug #19501

closed

unsetup should remove all sharing permissions for the deactivated user

Added by Tom Clegg 5 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
10/17/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Currently "unsetup" removes VM login and repo perms, deletes SSH keys and API tokens, etc., but retains collection/project-sharing permissions. This is not desirable because
  • if the user is re-setup, they will have access to the previously shared items, which the admin might not expect/desire
  • the deactivated user may appear in "currently shared with..." lists, which seems confusing

There is a slight wrinkle here that "manage" permission links are deleted by unsetup. This appears to be an accident: the comment suggests only (Arvados-hosted) repository permissions are deleted, but the db query is not restricted to repos.

    # delete repo_perms for this user                                                                                                                                                       
    Link.where(tail_uuid: self.uuid,
               link_class: 'permission',
               name: 'can_manage').destroy_all

Subtasks 1 (0 open1 closed)

Task #19506: Review 19501-unsetup-permissionsResolvedTom Clegg10/17/2022

Actions
Actions #1

Updated by Peter Amstutz 5 months ago

  • Assigned To set to Tom Clegg
Actions #2

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-09-28 sprint to 2022-10-12 sprint
Actions #3

Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-10-12 sprint to 2022-10-26 sprint
Actions #4

Updated by Tom Clegg 4 months ago

  • Status changed from New to In Progress
Actions #6

Updated by Lucas Di Pentima 4 months ago

Sorry for the delay, this LGTM.

Actions #7

Updated by Tom Clegg 4 months ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF