Project

General

Profile

Actions
Copy link

Bug #19514

closed

Make sure services pick up config changes when the salt installer is run

Added by Peter Amstutz over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assigned To:
Lucas Di Pentima
Category:
Deployment
Target version:
2022-12-07 Sprint
Story points:
1.0

Description

Customer made a change to the config file (adding cloud instance types) and re-ran the installer. The config file was updated on the nodes, but the services did not pick up the config change.

The solution was to manually restart arvados-controller, nginx and arvados-dispatch-cloud, but the expectation was that these services should have been restarted by salt (and/or we implement the ability to detect and respond to config changes automatically).

Subtasks 1 (0 open — 1 closed)

Task #19610: ReviewClosedPeter Amstutz12/01/2022Actions
Actions
Copy link
 #1

Updated by Peter Amstutz over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz over 1 year ago

  • Subject changed from Make sure services pick up config changes when the installer is run to Make sure services pick up config changes when the salt installer is run
Actions
Copy link
 #3

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2022-10-12 sprint to 2022-10-26 sprint
Actions
Copy link
 #4

Updated by Peter Amstutz over 1 year ago

Check to see what it does now -- difference between reload/restart, check what the systemd unit files do.

Actions
Copy link
 #5

Updated by Lucas Di Pentima over 1 year ago

  • Assigned To set to Lucas Di Pentima
Actions
Copy link
 #6

Updated by Lucas Di Pentima over 1 year ago

  • Status changed from New to In Progress
Actions
Copy link
 #7

Updated by Lucas Di Pentima over 1 year ago

  • Target version changed from 2022-10-26 sprint to 2022-11-09 sprint
Actions
Copy link
 #8

Updated by Lucas Di Pentima over 1 year ago

  • Target version changed from 2022-11-09 sprint to 2022-11-23 sprint
Actions
Copy link
 #9

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2022-11-23 sprint to 2022-12-07 Sprint
Actions
Copy link
 #10

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2022-12-07 Sprint to 2022-12-21 Sprint
Actions
Copy link
 #11

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2022-12-21 Sprint to 2023-01-18 sprint
Actions
Copy link
 #12

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2023-01-18 sprint to 2023-02-01 sprint
Actions
Copy link
 #13

Updated by Lucas Di Pentima over 1 year ago

I have been doing manual tests, both on single and multi host installations, and both arvados-controller and arvados-dispatch-cloud get restarted correctly after a config change.

The config change that I did was just setting up a custom message in Workbench.WelcomePageHTML at the local_config_dir/pillars/arvados.sls file.

Without being able to reproduce the issue, it's difficult to know what was the problem.

In the arvados salt formula, every service has a running.sls file that describes each running services, for example arvados/dispatcher/service/running.sls:

arvados-dispatcher-service-running-service-running:
  service.running:
    - name: {{ arvados.dispatcher.service.name }}
    - enable: true
    - watch:
      - sls: {{ sls_config_file }}
    - require:
      - pkg: arvados-dispatcher-package-install-pkg-installed

The service.running.watch.sls parameter makes the service restart when the config file changes. Service reload doesn't happen unless a service.running.reload: true is set, and it isn't the case in our formula.

Actions
Copy link
 #14

Updated by Lucas Di Pentima over 1 year ago

  • Story points set to 1.0
  • Target version changed from 2023-02-01 sprint to 2022-12-07 Sprint
Actions
Copy link
 #15

Updated by Lucas Di Pentima over 1 year ago

  • Status changed from In Progress to Closed
Actions
Copy link

Also available in: Atom PDF