Arvados

wb2 testing has found that when sending request params to controller using content-type: multipart/form-data, the params are ignored, and sometimes the response is truncated.

2022/10/04 16:45:45 [error] 24852#24852: *138 recv() failed (104: Connection reset by peer) while sending to client, client: 10.2.3.4, server: pirca.arvadosapi.com, request: "POST /arvados/v1/users?_method=GET&limit=1000 HTTP/2.0", upstream: "http://127.0.0.1:8003/arvados/v1/users?_method=GET", host: "pirca.arvadosapi.com", referrer: "https://localhost:3000/" 

• nginx proxies client request using content-type multipart/form-data
• controller does not support multipart/form-data, and does not even read the request body
• controller sends 200 response and hangs up
• while forwarding the response to client, nginx gets a write error sending the request body (because controller hung up)
• this is a protocol error, so nginx writes an error log and terminates the [http2] client connection

The Nginx error message "recv() failed while sending to client" sounds like the error originated on the client connection rather than the upstream connection, so the details might not be exactly right here, but nonetheless it seems likely the problem is caused by the unread request body.

Proposed fix: in (*router)loadRequestParams() in source:lib/controller/router/request.go, if request content-type is multipart/form-data, either read and parse the body accordingly, or error out and fail the request.