Bug #19603
closed
Installer fix to support container shell
Description
For container shell to work, nginx needs to be configured to allow connection upgrade requests to establish the proxy forward to the container.
Here is the change
https://doc.arvados.org/v2.2/admin/upgrading.html
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "upgrade";
Updated by Lucas Di Pentima about 2 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima about 2 years ago
Updates at c7d5ee39c - branch 19603-installer-container-shell-fix
- Adds nginx configurations to the 3 cases: single host [single|multi] hostname, and multi host.
- Manually tested that config is applied correctly on the single host version.
Updated by Peter Amstutz about 2 years ago
Could you also add a section to the upgrading notes that says if you used the installer, you should apply this fix when you upgrade?
Otherwise LGTM
Updated by Lucas Di Pentima about 2 years ago
Updates at ae1418e33
- Adds upgrade note as suggested.
Updated by Peter Amstutz about 2 years ago
Lucas Di Pentima wrote in #note-7:
Updates at ae1418e33
- Adds upgrade note as suggested.
I was thinking we would be a little more specific about what changed.
But actually my current idea is that we make a diff of what changed in the template and link to that on the upgrading page, and advise people to apply the patch (automatically or manually). So that might be something we incorporate into the release process. I just added this as #19622, so we'll deal with it there. Your current note is fine, LGTM.
Updated by Peter Amstutz about 2 years ago
- Related to Support #19622: Upgrade notes includes links to patches of what changed in install templates between versions added
Updated by Lucas Di Pentima about 2 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|bccafef2bb4d421618cea04b9faa3655cf83755b.