Project

General

Profile

Actions

Bug #19603

closed

Installer fix to support container shell

Added by Peter Amstutz 4 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Target version:
Start date:
10/14/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

For container shell to work, nginx needs to be configured to allow connection upgrade requests to establish the proxy forward to the container.

Here is the change

https://doc.arvados.org/v2.2/admin/upgrading.html

    proxy_set_header      Upgrade           $http_upgrade;
    proxy_set_header      Connection        "upgrade";

Subtasks 1 (0 open1 closed)

Task #19604: Review 19603-installer-container-shell-fixResolvedLucas Di Pentima10/14/2022

Actions

Related issues

Related to Arvados - Support #19622: Upgrade notes includes links to patches of what changed in install templates between versionsNewPeter Amstutz

Actions
Actions #1

Updated by Peter Amstutz 4 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 4 months ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz 4 months ago

  • Assigned To set to Lucas Di Pentima
Actions #4

Updated by Lucas Di Pentima 4 months ago

  • Status changed from New to In Progress
Actions #5

Updated by Lucas Di Pentima 4 months ago

Updates at c7d5ee39c - branch 19603-installer-container-shell-fix

  • Adds nginx configurations to the 3 cases: single host [single|multi] hostname, and multi host.
  • Manually tested that config is applied correctly on the single host version.
Actions #6

Updated by Peter Amstutz 4 months ago

Could you also add a section to the upgrading notes that says if you used the installer, you should apply this fix when you upgrade?

Otherwise LGTM

Actions #7

Updated by Lucas Di Pentima 4 months ago

Updates at ae1418e33

  • Adds upgrade note as suggested.
Actions #8

Updated by Peter Amstutz 4 months ago

Lucas Di Pentima wrote in #note-7:

Updates at ae1418e33

  • Adds upgrade note as suggested.

I was thinking we would be a little more specific about what changed.

But actually my current idea is that we make a diff of what changed in the template and link to that on the upgrading page, and advise people to apply the patch (automatically or manually). So that might be something we incorporate into the release process. I just added this as #19622, so we'll deal with it there. Your current note is fine, LGTM.

Actions #9

Updated by Peter Amstutz 4 months ago

  • Related to Support #19622: Upgrade notes includes links to patches of what changed in install templates between versions added
Actions #10

Updated by Lucas Di Pentima 3 months ago

  • Status changed from In Progress to Resolved
Actions #11

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF