Project

General

Profile

Actions

Bug #19620

closed

Remove old keepstore S3 driver on arvados 2.6.0

Added by Lucas Di Pentima over 1 year ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Start date:
04/14/2023
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0
Release relationship:
Auto

Description

We've enabled by default the Volumes.x.DriverParameters.UseAWSS3v2Driver setting in version 2.5.0, for 2.6.0 the old driver code & config knob should be removed.

Update release notes to mention the key is gone.

Config should ignore the old key and print a warning about an unknown/obsolete key.


Subtasks 1 (0 open1 closed)

Task #20321: Review 19620-remove-old-s3-driverResolvedTom Clegg04/14/2023

Actions
Actions #1

Updated by Peter Amstutz about 1 year ago

  • Release deleted (47)
  • Target version set to 2023-03-01 sprint
Actions #2

Updated by Peter Amstutz about 1 year ago

  • Target version changed from 2023-03-01 sprint to To be groomed
Actions #3

Updated by Peter Amstutz 11 months ago

  • Story points set to 1.0
  • Description updated (diff)
Actions #4

Updated by Peter Amstutz 11 months ago

  • Target version changed from To be groomed to To be scheduled
Actions #5

Updated by Peter Amstutz 11 months ago

  • Target version changed from To be scheduled to Development 2023-04-26 sprint
Actions #6

Updated by Tom Clegg 11 months ago

  • Assigned To set to Tom Clegg
Actions #7

Updated by Tom Clegg 10 months ago

  • Status changed from New to In Progress
Actions #9

Updated by Brett Smith 10 months ago

Tom Clegg wrote in #note-8:

19620-remove-old-s3-driver @ cefc46389792e233ee5db00da2a22a68e54e0a69 -- developer-run-tests: #3593

What's here is good. Does it make sense to completely remove the goamz dependency as part of this branch too? (git grep goamz)

If there's some reason that should be handled separately, please make a follow-up ticket but this is good to merge as-is. Thanks.

Actions #10

Updated by Tom Clegg 10 months ago

Brett Smith wrote in #note-9:

What's here is good. Does it make sense to completely remove the goamz dependency as part of this branch too? (git grep goamz)

Keep-web was still using its Key and ListResp structs, but they're trivial, so I just added them.

We still use the goamz s3 client in keep-web tests, though. Added #20373.

Does "only used in test code" seem like a better line to stop at here?

19620-remove-old-s3-driver @ f5a90a8dd208596aa8ce8cfd3086bd367b84b147 -- developer-run-tests: #3605

Actions #11

Updated by Brett Smith 10 months ago

Tom Clegg wrote in #note-10:

Keep-web was still using its Key and ListResp structs, but they're trivial, so I just added them.

We still use the goamz s3 client in keep-web tests, though. Added #20373.

Does "only used in test code" seem like a better line to stop at here?

Sure, that works for me. This is good to merge, thanks.

Actions #12

Updated by Tom Clegg 10 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #13

Updated by Peter Amstutz 6 months ago

  • Release set to 66
Actions

Also available in: Atom PDF