Bug #19620
closed
Remove old keepstore S3 driver on arvados 2.6.0
Added by Lucas Di Pentima almost 2 years ago.
Updated about 1 year ago.
Release relationship:
Auto
Description
We've enabled by default the Volumes.x.DriverParameters.UseAWSS3v2Driver
setting in version 2.5.0, for 2.6.0 the old driver code & config knob should be removed.
Update release notes to mention the key is gone.
Config should ignore the old key and print a warning about an unknown/obsolete key.
- Release deleted (
47)
- Target version set to 2023-03-01 sprint
- Target version changed from 2023-03-01 sprint to Future
- Story points set to 1.0
- Description updated (diff)
- Target version changed from Future to To be scheduled
- Target version changed from To be scheduled to Development 2023-04-26 sprint
- Assigned To set to Tom Clegg
- Status changed from New to In Progress
Tom Clegg wrote in #note-8:
19620-remove-old-s3-driver @ cefc46389792e233ee5db00da2a22a68e54e0a69 -- developer-run-tests: #3593 ![](https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=3593)
What's here is good. Does it make sense to completely remove the goamz
dependency as part of this branch too? (git grep goamz
)
If there's some reason that should be handled separately, please make a follow-up ticket but this is good to merge as-is. Thanks.
Brett Smith wrote in #note-9:
What's here is good. Does it make sense to completely remove the goamz
dependency as part of this branch too? (git grep goamz
)
Keep-web was still using its Key and ListResp structs, but they're trivial, so I just added them.
We still use the goamz s3 client in keep-web tests, though. Added #20373.
Does "only used in test code" seem like a better line to stop at here?
19620-remove-old-s3-driver @ f5a90a8dd208596aa8ce8cfd3086bd367b84b147 -- developer-run-tests: #3605 ![](https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=3605)
Tom Clegg wrote in #note-10:
Keep-web was still using its Key and ListResp structs, but they're trivial, so I just added them.
We still use the goamz s3 client in keep-web tests, though. Added #20373.
Does "only used in test code" seem like a better line to stop at here?
Sure, that works for me. This is good to merge, thanks.
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Also available in: Atom
PDF