Bug #19631
closed
Subprocesses panel is not labeled
Description
The "subprocesses" panel isn't labeled "subprocesses" like every other panel on this page.
Updated by Peter Amstutz over 1 year ago
- Assigned To changed from Stephen Smith to Lucas Di Pentima
Updated by Lucas Di Pentima over 1 year ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima over 1 year ago
Updates at arvados-workbench2|1c5ffeeb - branch 19631-subprocess-panel-title
Test run: developer-tests-workbench2: #984
- Passes title prop to
DataExplorercomponent on the Subprocesses panel. - Fixes panel's toolbar icons alignment.
- Removes unused CSS styling code from the Search component.
To better align the search component vertically, we'll need to change the way the input shows its label: when the user clicks on the input, the label moves up, and that's why its marginTop is set to 16px in the default Material-UI theme.
Updated by Peter Amstutz over 1 year ago
Lucas Di Pentima wrote in #note-5:
Updates at arvados-workbench2|1c5ffeeb - branch
19631-subprocess-panel-title
Test run: developer-tests-workbench2: #984
- Passes title prop to
DataExplorercomponent on the Subprocesses panel.- Fixes panel's toolbar icons alignment.
- Removes unused CSS styling code from the Search component.
To better align the search component vertically, we'll need to change the way the input shows its label: when the user clicks on the input, the label moves up, and that's why its
marginTopis set to 16px in the default Material-UI theme.
This LGTM, thanks!
Updated by Lucas Di Pentima over 1 year ago
- Status changed from In Progress to Resolved
Applied in changeset arvados-workbench2|aaeb8d7b243400efd235284c177c6046c39a67fe.