Project

General

Profile

Actions

Bug #19631

closed

Subprocesses panel is not labeled

Added by Peter Amstutz 3 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
10/27/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

The "subprocesses" panel isn't labeled "subprocesses" like every other panel on this page.


Subtasks 1 (0 open1 closed)

Task #19642: Review 19631-subprocess-panel-titleResolvedPeter Amstutz10/27/2022

Actions
Actions #1

Updated by Peter Amstutz 3 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 3 months ago

  • Assigned To set to Stephen Smith
Actions #3

Updated by Peter Amstutz 3 months ago

  • Assigned To changed from Stephen Smith to Lucas Di Pentima
Actions #4

Updated by Lucas Di Pentima 3 months ago

  • Status changed from New to In Progress
Actions #5

Updated by Lucas Di Pentima 3 months ago

Updates at arvados-workbench2|1c5ffeeb - branch 19631-subprocess-panel-title
Test run: developer-tests-workbench2: #984

  • Passes title prop to DataExplorer component on the Subprocesses panel.
  • Fixes panel's toolbar icons alignment.
  • Removes unused CSS styling code from the Search component.

To better align the search component vertically, we'll need to change the way the input shows its label: when the user clicks on the input, the label moves up, and that's why its marginTop is set to 16px in the default Material-UI theme.

Actions #6

Updated by Peter Amstutz 3 months ago

Lucas Di Pentima wrote in #note-5:

Updates at arvados-workbench2|1c5ffeeb - branch 19631-subprocess-panel-title
Test run: developer-tests-workbench2: #984

  • Passes title prop to DataExplorer component on the Subprocesses panel.
  • Fixes panel's toolbar icons alignment.
  • Removes unused CSS styling code from the Search component.

To better align the search component vertically, we'll need to change the way the input shows its label: when the user clicks on the input, the label moves up, and that's why its marginTop is set to 16px in the default Material-UI theme.

This LGTM, thanks!

Actions #7

Updated by Lucas Di Pentima 3 months ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF