https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422022-10-24T13:38:09ZArvadosArvados - Bug #19631: Subprocesses panel is not labeledhttps://dev.arvados.org/issues/19631?journal_id=1072602022-10-24T13:38:09ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/107260/diff?detail_id=103920">diff</a>)</li></ul> Arvados - Bug #19631: Subprocesses panel is not labeledhttps://dev.arvados.org/issues/19631?journal_id=1073332022-10-26T15:40:11ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Stephen Smith</i></li></ul> Arvados - Bug #19631: Subprocesses panel is not labeledhttps://dev.arvados.org/issues/19631?journal_id=1074532022-10-27T14:03:23ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> changed from <i>Stephen Smith</i> to <i>Lucas Di Pentima</i></li></ul> Arvados - Bug #19631: Subprocesses panel is not labeledhttps://dev.arvados.org/issues/19631?journal_id=1074582022-10-27T15:38:20ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #19631: Subprocesses panel is not labeledhttps://dev.arvados.org/issues/19631?journal_id=1074602022-10-27T15:47:07ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="19631: Removes unused styling code on Search component. Arvados-DCO-1.1-Signed-off-by: Lucas Di ..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/1c5ffeebd86ab557913b098498825eaa847f4877">arvados-workbench2|1c5ffeeb</a> - branch <code>19631-subprocess-panel-title</code><br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/984/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/984/">developer-tests-workbench2: #984 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=984" alt="" /></a></a></p>
<ul>
<li>Passes title prop to <code>DataExplorer</code> component on the Subprocesses panel.</li>
<li>Fixes panel's toolbar icons alignment.</li>
<li>Removes unused CSS styling code from the Search component.</li>
</ul>
<p>To better align the search component vertically, we'll need to change the way the input shows its label: when the user clicks on the input, the label moves up, and that's why its <code>marginTop</code> is set to 16px in the default Material-UI theme.</p> Arvados - Bug #19631: Subprocesses panel is not labeledhttps://dev.arvados.org/issues/19631?journal_id=1074742022-10-28T14:11:05ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Lucas Di Pentima wrote in <a href="#note-5">#note-5</a>:</p>
<blockquote>
<p>Updates at <a class="changeset" title="19631: Removes unused styling code on Search component. Arvados-DCO-1.1-Signed-off-by: Lucas Di ..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/1c5ffeebd86ab557913b098498825eaa847f4877">arvados-workbench2|1c5ffeeb</a> - branch <code>19631-subprocess-panel-title</code><br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/984/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/984/">developer-tests-workbench2: #984 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=984" alt="" /></a></a></p>
<ul>
<li>Passes title prop to <code>DataExplorer</code> component on the Subprocesses panel.</li>
<li>Fixes panel's toolbar icons alignment.</li>
<li>Removes unused CSS styling code from the Search component.</li>
</ul>
<p>To better align the search component vertically, we'll need to change the way the input shows its label: when the user clicks on the input, the label moves up, and that's why its <code>marginTop</code> is set to 16px in the default Material-UI theme.</p>
</blockquote>
<p>This LGTM, thanks!</p> Arvados - Bug #19631: Subprocesses panel is not labeledhttps://dev.arvados.org/issues/19631?journal_id=1074912022-10-28T17:14:18ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '19631-subprocess-panel-title'. Closes #19631 Arvados-DCO-1.1-Signed-off-by: Lucas ..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/aaeb8d7b243400efd235284c177c6046c39a67fe">arvados-workbench2|aaeb8d7b243400efd235284c177c6046c39a67fe</a>.</p> Arvados - Bug #19631: Subprocesses panel is not labeledhttps://dev.arvados.org/issues/19631?journal_id=1091022022-12-13T15:33:23ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>47</i></li></ul>