Project

General

Profile

Actions

Bug #19683

closed

arvbox broken by ruby dev dependency

Added by Peter Amstutz 3 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Tests
Target version:
Start date:
11/01/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Arvbox demo currently doesn't build because the login-sync step needs a dev version of the arvados gem but the arvbox scripts haven't been updated to install it before installing other ruby stuff.


Subtasks 1 (0 open1 closed)

Task #19685: Review 19683-arvbox-rubysdk-fixResolvedPeter Amstutz11/01/2022

Actions
Actions #1

Updated by Peter Amstutz 3 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz 3 months ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz 3 months ago

  • Assigned To set to Lucas Di Pentima
Actions #4

Updated by Lucas Di Pentima 3 months ago

Updates at 3070a6d - branch 19683-arvbox-rubysdk-fix
Test run: developer-run-tests: #3349

  • Conditionally builds && install the arvados gem dev version so that login-sync can be installed.
Actions #5

Updated by Peter Amstutz 3 months ago

Lucas Di Pentima wrote in #note-4:

Updates at 3070a6d - branch 19683-arvbox-rubysdk-fix
Test run: developer-run-tests: #3349

  • Conditionally builds && install the arvados gem dev version so that login-sync can be installed.

Shell script style comments:

instead of test "$(flock $GEMLOCK /var/lib/arvados/bin/gem list | grep arvados | grep dev | wc -l)" = "0" does test -z "$(flock $GEMLOCK /var/lib/arvados/bin/gem list | grep arvados | grep dev)" work?

Instead of cd /usr/src/arvados/sdk/ruby and then cd - you can do it in a subshell (cd /usr/src/arvados/sdk/ruby && ...) and you don't need the cd -

Actions #6

Updated by Lucas Di Pentima 3 months ago

Updates at 9e764431d
Test run: developer-run-tests: #3350

  • Improves code style
  • Improves arvados gem pattern matching
Actions #8

Updated by Peter Amstutz 3 months ago

Lucas Di Pentima wrote in #note-7:

WB integration tests re-run: developer-run-tests-apps-workbench-integration: #3599

LGTM

Actions #9

Updated by Lucas Di Pentima 3 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #10

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF