Project

General

Profile

Actions

Bug #19684

closed

Crash on workflow containing secrets

Added by Peter Amstutz 3 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
11/02/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

This hard crashes:

https://workbench2.tordo.arvadosapi.com/processes/tordo-xvhdp-z0lth3b4b6yv0hp

What is happening there is that the value that actually shows up in inputs.json is actually a level of indirection, it's a {$include: file} instead of the proper value.

I don't need it to resolve $include, but I do need it to not crash.

A layer of "do some sensible error handling when expected CWL input parameter type and the actual type in input.json don't match expectations" would be fine. It can just say "I can't show this value".


Files

Screenshot_20221102_171520.png (57.8 KB) Screenshot_20221102_171520.png Stephen Smith, 11/02/2022 09:51 PM

Subtasks 1 (0 open1 closed)

Task #19693: Review 19684-io-include-import-bugResolvedPeter Amstutz11/02/2022

Actions
Actions #1

Updated by Peter Amstutz 3 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 3 months ago

  • Assigned To set to Stephen Smith
Actions #3

Updated by Stephen Smith 3 months ago

Changes at arvados-workbench2|fe41be6c6bcc21fc0c7c6450485a1d1f7955ebe5
Tests developer-tests-workbench2: #996

  • Catches objects in primitive types and shows "Cannot display value"
  • For File/Directory, I check for $include / $import keys on the object and display the message if found

Actions #4

Updated by Peter Amstutz 3 months ago

Stephen Smith wrote in #note-3:

Changes at arvados-workbench2|fe41be6c6bcc21fc0c7c6450485a1d1f7955ebe5
Tests developer-tests-workbench2: #996

  • Catches objects in primitive types and shows "Cannot display value"
  • For File/Directory, I check for $include / $import keys on the object and display the message if found

This LGTM, thanks!

Actions #5

Updated by Stephen Smith 3 months ago

  • Status changed from New to Resolved
Actions #6

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF