https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422014-01-28T00:55:03ZArvadosArvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=72032014-01-28T00:55:03ZTom Cleggtom@curii.com
<ul><li><strong>Subject</strong> changed from <i>Create, browse, display, and share groups/projects in Workbench (sets of collections, pipelines, etc)</i> to <i>Create, browse, display, set-default, and share groups/projects in Workbench (sets of collections, pipelines, etc)</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=72402014-01-29T10:25:19ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Story points</strong> set to <i>2.0</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=73362014-02-05T01:55:37ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> set to <i>2014-05-07 Storing and Organizing Data</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=74132014-02-11T04:00:32ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>2014-05-07 Storing and Organizing Data</i> to <i>2014-03-05 Data management</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=74142014-02-11T04:02:03ZTom Cleggtom@curii.com
<ul><li><strong>Subject</strong> changed from <i>Create, browse, display, set-default, and share groups/projects in Workbench (sets of collections, pipelines, etc)</i> to <i>Create groups and use them like folders to manage objects in Workbench.</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=75662014-02-12T15:37:57ZTom Cleggtom@curii.com
<ul><li><strong>Subject</strong> changed from <i>Create groups and use them like folders to manage objects in Workbench.</i> to <i>Create groups and use them like project folders to manage objects in Workbench.</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=79642014-02-25T16:35:46ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>2014-03-05 Data management</i> to <i>2014-05-07 Storing and Organizing Data</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=83362014-03-04T15:24:05ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/8336/diff?detail_id=6023">diff</a>)</li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=83372014-03-04T15:42:36ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/8337/diff?detail_id=6024">diff</a>)</li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=88502014-03-24T14:16:24ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>2014-05-07 Storing and Organizing Data</i> to <i>2014-04-16 Dev tools and data/resource management</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=88512014-03-24T14:16:40ZTom Cleggtom@curii.com
<ul><li><strong>Story points</strong> changed from <i>2.0</i> to <i>5.0</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=88522014-03-24T14:16:57ZTom Cleggtom@curii.com
<ul><li><strong>Story points</strong> changed from <i>5.0</i> to <i>3.0</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=90422014-03-26T16:49:40ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> changed from <i>2014-04-16 Dev tools and data/resource management</i> to <i>2014-05-07 Storing and Organizing Data</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=92262014-04-04T11:54:37ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> deleted (<del><i>2014-05-07 Storing and Organizing Data</i></del>)</li><li><strong>Release</strong> changed from <i>4</i> to <i>8</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=92492014-04-04T14:09:27ZTom Cleggtom@curii.com
<ul><li><strong>Target version</strong> set to <i>2014-05-07 Storing and Organizing Data</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=92542014-04-04T14:10:29ZTom Cleggtom@curii.com
<ul><li><strong>Story points</strong> changed from <i>3.0</i> to <i>5.0</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=95172014-04-14T15:04:08ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/9517/diff?detail_id=7504">diff</a>)</li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=95202014-04-14T15:10:26ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/9520/diff?detail_id=7507">diff</a>)</li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=95272014-04-14T16:21:11ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> <a href="/attachments/259">Screenshot from 2014-04-14 16_19_58.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/259/Screenshot%20from%202014-04-14%2016_19_58.png">Screenshot from 2014-04-14 16_19_58.png</a> added</li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=95922014-04-16T09:16:21ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/9592/diff?detail_id=7592">diff</a>)</li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=96872014-04-16T15:20:46ZTom Cleggtom@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Tom Clegg</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=100722014-05-01T10:52:23ZTom Cleggtom@curii.com
<ul><li><strong>File</strong> <a href="/attachments/264">Screenshot from 2014-05-01 07_50_40.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/264/Screenshot%20from%202014-05-01%2007_50_40.png">Screenshot from 2014-05-01 07_50_40.png</a> added</li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=101622014-05-05T18:06:24ZBrett Smithbrett.smith@curii.com
<ul></ul><p>I'm looking at c52a78b3, and I'm calling it now: Tom wins this sprint review. No other demo could possibly compare to this branch for raw eye candy. "Oh, we can run Crunch jobs in Docker containers now? That's nice. Me? Oh, I just MADE THE WORKBENCH INTERFACE GLORIOUS. BEHOLD my expansive collection of beautiful screenshots!" I can hear the business team ohh-ing and ahh-ing already.</p>
<p>Seriously, this is very impressive work. Kudos. My comments feel even more nit-pickier than usual by comparison (and really, they're mostly questions for understanding rather than suggestions for improvements), but here goes anyway:</p>
<ul>
<li>ActionsController calls <code>#send(sym.to_s)</code>. Sending symbols is allowed (and I think preferred), so you can omit <code>.to_s</code>.</li>
<li>FoldersController#index returns @object. What is that for index methods?</li>
<li>The first folder integration test has no assertion. Could you <code>assert find('.panel').has_text?('I just edited this.')</code>?</li>
<li>Maybe related, I'm curious why you removed some of the intermediate assertions in the existing integration tests.</li>
<li>I'm not wild about the cloud icon for virtual machines in the navigation sidebar. Virtual machines may be <em>in</em> the cloud, but they are not themselves the cloud. Is there a generic computer/workstation icon? A work desk might make sense, too, since the virtual machine is where people work on Crunch scripts.</li>
</ul>
<p>Thanks much.</p> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=101642014-05-05T20:45:26ZTom Cleggtom@curii.com
<ul></ul><p>Brett Smith wrote:</p>
<blockquote>
<p>Seriously, this is very impressive work. Kudos. My comments feel even more nit-pickier than usual by comparison (and really, they're mostly questions for understanding rather than suggestions for improvements), but here goes anyway:</p>
</blockquote>
<p>Thanks!</p>
<blockquote>
<ul>
<li>ActionsController calls <code>#send(sym.to_s)</code>. Sending symbols is allowed (and I think preferred), so you can omit <code>.to_s</code>.</li>
</ul>
</blockquote>
<p>Indeed, fixed.</p>
<blockquote>
<ul>
<li>FoldersController#index returns @object. What is that for index methods?</li>
</ul>
</blockquote>
<p>Hm, not actually sure why that got there. Removed.</p>
<blockquote>
<ul>
<li>The first folder integration test has no assertion. Could you <code>assert find('.panel').has_text?('I just edited this.')</code>?</li>
</ul>
</blockquote>
<p>Fixed. (I had commented it out pending discovering the magic incantation to reconcile Capybara with x-editable. <code>"visit current_path"</code> isn't perfect but better than nothing.)</p>
<blockquote>
<ul>
<li>Maybe related, I'm curious why you removed some of the intermediate assertions in the existing integration tests.</li>
</ul>
</blockquote>
<p>Some of the tests changed from "click the uuid link" to "click the Show button on the row with this uuid". While I was updating them, noticing <code>find()</code> errors out if the links don't exist, I figured the extra <code>assert</code> before <code>find().click</code> doesn't serve any purpose (unless it has a helpful error message).</p>
<blockquote>
<ul>
<li>I'm not wild about the cloud icon for virtual machines in the navigation sidebar. Virtual machines may be <em>in</em> the cloud, but they are not themselves the cloud. Is there a generic computer/workstation icon? A work desk might make sense, too, since the virtual machine is where people work on Crunch scripts.</li>
</ul>
</blockquote>
<p>Yeah, I'm not super keen on it either. I've changed it to the "terminal" icon, see how that goes. See <a class="external" href="http://fortawesome.github.io/Font-Awesome/icons/">http://fortawesome.github.io/Font-Awesome/icons/</a></p>
<p>Latest: <a class="changeset" title="Remove duplicate ERROR_ACTIONS constant from merge." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/16c58b75712ad4332d55e490d20b3946d2e05008">16c58b7</a></p> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=101672014-05-05T21:05:46ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=101732014-05-06T09:22:19ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>New</i></li></ul><p>On <a class="changeset" title="Remove duplicate ERROR_ACTIONS constant from merge." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/16c58b75712ad4332d55e490d20b3946d2e05008">16c58b75</a></p>
<p>Tom Clegg wrote:</p>
<blockquote>
<p>Brett Smith wrote:</p>
<blockquote>
<ul>
<li>The first folder integration test has no assertion. Could you <code>assert find('.panel').has_text?('I just edited this.')</code>?</li>
</ul>
</blockquote>
<p>Fixed. (I had commented it out pending discovering the magic incantation to reconcile Capybara with x-editable. <code>"visit current_path"</code> isn't perfect but better than nothing.)</p>
</blockquote>
<p>You say below that <code>find</code> errors out if it doesn't find what it's looking for. So won't this always either pass or raise an exception? Or does that only apply when you try to <code>click</code> the result?</p>
<blockquote><blockquote>
<ul>
<li>Maybe related, I'm curious why you removed some of the intermediate assertions in the existing integration tests.</li>
</ul>
</blockquote>
<p>Some of the tests changed from "click the uuid link" to "click the Show button on the row with this uuid". While I was updating them, noticing <code>find()</code> errors out if the links don't exist, I figured the extra <code>assert</code> before <code>find().click</code> doesn't serve any purpose (unless it has a helpful error message).</p>
</blockquote>
<p>+1 to helpful messages. My personal feeling is that an assert is a much stronger statement of intent than an uncaught exception. A failed assertion says, "I expected this behavior, and didn't get it." An exception leaves open questions to answer: is this bug in the test code, or in the application? And if it's in the application, is the expected behavior important, or not? So I like redundant assertions because I feel like they help others better interpret the results—e.g., many of my recent controller tests <code>assert_response :success</code> even though they go on to check things that could only be true after success.</p>
<p>But this is a pretty open-ended style thing, and I can definitely agree that the subject's a little more slippery when you're talking about relatively fine-grained navigation of HTML. That's my two cents, but either way, once the specific test issue above is settled I'm happy (psyched, even) to see this branch merged.</p> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=101762014-05-06T09:24:25ZBrett Smithbrett.smith@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=101812014-05-06T12:48:55ZTom Cleggtom@curii.com
<ul></ul><p>Brett Smith wrote:</p>
<blockquote>
<p>On <a class="changeset" title="Remove duplicate ERROR_ACTIONS constant from merge." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/16c58b75712ad4332d55e490d20b3946d2e05008">16c58b75</a></p>
<p>You say below that <code>find</code> errors out if it doesn't find what it's looking for. So won't this always either pass or raise an exception? Or does that only apply when you try to <code>click</code> the result?</p>
</blockquote>
<p>That's true, the word "assert" doesn't actually do anything because failure results in an exception.</p>
<ul>
<li>Tried wrapping in "assert_nothing_raised", but that somehow causes <code>find()</code> to always fail.</li>
<li>Tried using the "message" option to <code>find()</code>, but that feature has been broken/removed from Capybara.</li>
<li><del>Added a comment (in <a class="changeset" title="Replace unfailable assert() with a comment explaining what it means for find() to raise an except..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/a848b6ea430ee2b2c1daee80e846d4d3bd594920">a848b6e</a>) explaining that <code>find()</code> raises an exception if the tested behavior fails.</del></li>
<li>Added a <code>find?()</code> method (in <a class="changeset" title="Add find?() method so "assert find?(...), msg" can be used in test cases." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/32ca1dc4da9100a1a698d33a46c2919cf53fe606">32ca1dc</a>) to use with assert.</li>
</ul>
<pre><code class="ruby syntaxhl"><span class="o">+</span> <span class="n">assert</span><span class="p">(</span><span class="n">find?</span><span class="p">(</span><span class="s1">'.panel'</span><span class="p">,</span> <span class="ss">text: </span><span class="s1">'I just edited this.'</span><span class="p">),</span>
<span class="o">+</span> <span class="s2">"Description update did not survive page refresh"</span><span class="p">)</span>
</code></pre>
<p>Totally on board with improving our testing standards/patterns. In particular, valuable to make more clear in the tests which parts are "setting up the test" (rearrange as needed) and which parts are "behavior actually being tested" (when you touch this code, be careful that you are still testing this behavior!).</p> Arvados - Idea #1970: Create groups and use them like project folders to manage objects in Workbench.https://dev.arvados.org/issues/1970?journal_id=101872014-05-06T13:45:11ZAnonymous
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>95</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:fc4428224984cb71b961d17410205b535153c7f2.</p>