Actions
Bug #19700
closedProcess input panel JSON missing, also mishandles http URLs, also scrolling
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release:
Release relationship:
Auto
Description
Sorry I keep finding edge cases...
Example:
https://workbench2.tordo.arvadosapi.com/processes/tordo-xvhdp-u55x8qxyai66qu3
- the "input" parameter is a File object with a http URL. This is sort of a new requirement but we have a customer that wants to use http URLs in their input and then arvados-cwl-runner downloads the file on the fly. Workbench 2 seems to end up showing either "No value" or an incorrect link to keep-web.
- I think the easiest thing to do is just render http and https as a regular plain clickable hyperlink; if something shows up in the
location
field that doesn't start withkeep:
don't parse it, just render it as a link.
- I think the easiest thing to do is just render http and https as a regular plain clickable hyperlink; if something shows up in the
- I haven't managed to nail this down but sometimes the JSON tab is empty (it shows "[]") even when things are listed in the "Parameters" tab.
- I noticed this reviewing the log scrolling fix for Lucas, but then I checked and it is happening on main as well -- the space reserved for the table is slightly too small, causing a minor amount of scrolling that shouldn't happen, because the panel isn't at maximum horizontal size.
Updated by Peter Amstutz about 2 years ago
- Description updated (diff)
- Subject changed from Process input panel mishandles http URLs to Process input panel JSON missing, also mishandles http URLs
Updated by Peter Amstutz about 2 years ago
- Description updated (diff)
- Subject changed from Process input panel JSON missing, also mishandles http URLs to Process input panel JSON missing, also mishandles http URLs, also scrolling
Updated by Peter Amstutz about 2 years ago
- Target version changed from 2022-11-09 sprint to 2022-11-23 sprint
Updated by Stephen Smith about 2 years ago
- Status changed from New to In Progress
Updated by Peter Amstutz about 2 years ago
- Target version changed from 2022-11-23 sprint to 2022-12-07 Sprint
Updated by Stephen Smith about 2 years ago
Changes at arvados-workbench2|9183367d596ef3082d0e81ec459c9813ed69e805
Tests developer-tests-workbench2: #1012
- Display http/s file inputs as links
- Tweak io card height to eliminate persistent scrollbar unless content overflows
- Add test for url file input
Updated by Peter Amstutz about 2 years ago
http links look great.
Scrollbar is gone.
I think the empty Input parameters on the JSON tab. It looks like it happens when you visit the process page while it is in the "Running" state.
Updated by Stephen Smith about 2 years ago
Changes at arvados-workbench2|bf5703f285ed90bb3334f531ce0a46e5e00d122f
Tests developer-tests-workbench2: #1013
- Fixed using incorrect type and check for empty raw inputs - caused store to not be updated if empty inputs got loaded first
Updated by Peter Amstutz about 2 years ago
Stephen Smith wrote in #note-10:
Changes at arvados-workbench2|bf5703f285ed90bb3334f531ce0a46e5e00d122f
Tests developer-tests-workbench2: #1013
- Fixed using incorrect type and check for empty raw inputs - caused store to not be updated if empty inputs got loaded first
This is working now, LGTM!
Updated by Stephen Smith about 2 years ago
- Status changed from In Progress to Resolved
Actions