Bug #19715
closedPreserving destination still not working consistently
Description
- I click on a link, for example:
https://workbench2.tordo.arvadosapi.com/processes/tordo-xvhdp-u55x8qxyai66qu3 - My token is expired or for whatever reason I need to log in again, so I land on a login page.
- I click log in.
- I log in with Google.
- When I return, I am at the home project instead of the page for the link I clicked on.
Updated by Peter Amstutz almost 2 years ago
- Target version changed from 2022-12-07 Sprint to 2022-12-21 Sprint
Updated by Peter Amstutz almost 2 years ago
- Target version changed from 2022-12-21 Sprint to 2023-01-18 sprint
Updated by Peter Amstutz almost 2 years ago
- Target version changed from 2023-01-18 sprint to 2023-02-01 sprint
Updated by Peter Amstutz almost 2 years ago
- Target version changed from 2023-02-01 sprint to 2023-01-18 sprint
Updated by Stephen Smith over 1 year ago
Changes at arvados-workbench2|68abcff0f925ea12c0d74efdafbd6c74db82ae3b
Tests developer-tests-workbench2: #1056
- Added preservePath flag to logout action, switches between returning to the base WB2 path vs the path the user was located before logging out - now preserves path when session times out
Tested by setting clusterConfig.Workbench.IdleTimeout to a small number
Updated by Lucas Di Pentima over 1 year ago
Your fix looks good and solves a real issue, but I don't think it is one reported on this ticket.
At first, I couldn't reproduce the problem described on this ticket: not being logged into tordo
and clicking on the provided link using the current main
version, I correctly get sent to the process page.
After some config fiddling, I think I came up with the specific case reported here: If workbench2's IdleTimeout
is disabled or set to a value greater than TokenLifetime
, it won't auto-logout and while being logged into wb2 and, your token gets expired, that's when the described problem appears: wb2 attempts to make some request and receives a 401 error, sending the user to the login page and completely forgetting where the user should get forwarded after login.
In summary: your updates are helpful because they fix another bug, but I think the one reported is still present. For the pending fix, I think you could write a Cypress test and simulate the token expiration by updating it directly via API requests.
Updated by Peter Amstutz over 1 year ago
- Target version changed from 2023-01-18 sprint to 2023-02-01 sprint
Updated by Stephen Smith over 1 year ago
Changes at arvados-workbench2|e92b9b5472a0f32e40983b8e25e572e592691e41
Tests developer-tests-workbench2: #1061
- Also fixed when the token expires before WB2 notices or is invalidated server sided
- Modified token revokation test to ensure url is preserved
Updated by Stephen Smith over 1 year ago
- Status changed from In Progress to Resolved