Project

General

Profile

Actions

Bug #19840

closed

Gets confused by port numbers in docker image name

Added by Peter Amstutz about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Docker
Target version:
Start date:
12/08/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5
Release relationship:
Auto

Description

Customer is using a docker reference that looks like this:

docker.cloud.example.com:443/rrtest:samtools_jp_v1.6.1

arv-keepdocker splits on the first instance of ':' so the port number is messing it up -- it thinks "docker.cloud.example.com" is the name and "443/rrtest" is the tag (and the last part gets thrown away).

This case needs to be handled properly.


Subtasks 1 (0 open1 closed)

Task #19853: Review 19840-docker-port-numberResolvedTom Clegg12/08/2022

Actions

Related issues

Related to Arvados - Feature #8333: [SDKs] `arv keep docker` supports `repo:tag` image name schemeResolvedTom Clegg02/01/2016

Actions
Actions #1

Updated by Peter Amstutz about 2 months ago

  • Category set to Docker
  • Description updated (diff)
  • Subject changed from Gets confused by port numbers in docker id to Gets confused by port numbers in docker image name
Actions #2

Updated by Peter Amstutz about 2 months ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz about 2 months ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz about 2 months ago

  • Description updated (diff)
Actions #5

Updated by Tom Clegg about 2 months ago

  • Story points set to 0.5
Actions #6

Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Tom Clegg
Actions #7

Updated by Tom Clegg about 2 months ago

  • Status changed from New to In Progress
Actions #8

Updated by Tom Clegg about 2 months ago

  • Related to Feature #8333: [SDKs] `arv keep docker` supports `repo:tag` image name scheme added
Actions #9

Updated by Tom Clegg about 2 months ago

This bug was mostly fixed in #8333, but
  • when listing/searching images already stored in Keep, host:port/repo:tag was still being split as ("host", "port/repo:tag"), so the list output was wrong and upload would always re-upload even if the same image had already been uploaded.
  • when the explicit port happens to be 443, docker strips it off because it's redundant in an https url -- so after docker pull h:443/r:t succeeds, docker inspect h/r:t succeeds but docker inspect h:443/r:t fails. Since arv-keepdocker was doing the latter, it would always fail to save the image after pulling.

Fixed both issues and added tests.

19840-docker-port-number @ ed948e5ff97e22594d54845097dbea77048aa2fc -- developer-run-tests: #3409

Actions #10

Updated by Lucas Di Pentima about 2 months ago

This LGTM, thanks.

Actions #11

Updated by Tom Clegg about 2 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #12

Updated by Peter Amstutz about 2 months ago

  • Release set to 47
Actions

Also available in: Atom PDF