Gets confused by port numbers in docker image name
Customer is using a docker reference that looks like this:
arv-keepdocker splits on the first instance of ':' so the port number is messing it up -- it thinks "docker.cloud.example.com" is the name and "443/rrtest" is the tag (and the last part gets thrown away).
This case needs to be handled properly.
Updated by Tom Clegg about 2 months ago
- when listing/searching images already stored in Keep,
host:port/repo:tagwas still being split as
("host", "port/repo:tag"), so the list output was wrong and upload would always re-upload even if the same image had already been uploaded.
- when the explicit port happens to be
443, docker strips it off because it's redundant in an https url -- so after
docker pull h:443/r:tsucceeds,
docker inspect h/r:tsucceeds but
docker inspect h:443/r:tfails. Since
arv-keepdockerwas doing the latter, it would always fail to save the image after pulling.
Fixed both issues and added tests.