Actions
Bug #19840
closed
Gets confused by port numbers in docker image name
Story points:
0.5
Release:
Release relationship:
Auto
Description
Customer is using a docker reference that looks like this:
docker.cloud.example.com:443/rrtest:samtools_jp_v1.6.1
arv-keepdocker splits on the first instance of ':' so the port number is messing it up -- it thinks "docker.cloud.example.com" is the name and "443/rrtest" is the tag (and the last part gets thrown away).
This case needs to be handled properly.
Related issues
Updated by Peter Amstutz over 1 year ago
- Category set to Docker
- Description updated (diff)
- Subject changed from Gets confused by port numbers in docker id to Gets confused by port numbers in docker image name
Updated by Tom Clegg over 1 year ago
- Related to Feature #8333: [SDKs] `arv keep docker` supports `repo:tag` image name scheme added
Updated by Tom Clegg over 1 year ago
This bug was mostly fixed in #8333, but
- when listing/searching images already stored in Keep,
host:port/repo:tagwas still being split as("host", "port/repo:tag"), so the list output was wrong and upload would always re-upload even if the same image had already been uploaded. - when the explicit port happens to be
443, docker strips it off because it's redundant in an https url -- so afterdocker pull h:443/r:tsucceeds,docker inspect h/r:tsucceeds butdocker inspect h:443/r:tfails. Sincearv-keepdockerwas doing the latter, it would always fail to save the image after pulling.
Fixed both issues and added tests.
19840-docker-port-number @ ed948e5ff97e22594d54845097dbea77048aa2fc -- developer-run-tests: #3409
Updated by
Updated by Tom Clegg over 1 year ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados|a46c78bdc3c2136236e6fff2e17b32d3c78ca772.
Actions