https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422022-12-01T15:11:17ZArvadosArvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1086342022-12-01T15:11:17ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Category</strong> set to <i>Docker</i></li><li><strong>Description</strong> updated (<a title="View differences" href="/journals/108634/diff?detail_id=105318">diff</a>)</li><li><strong>Subject</strong> changed from <i>Gets confused by port numbers in docker id</i> to <i>Gets confused by port numbers in docker image name</i></li></ul> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1086352022-12-01T15:11:33ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/108635/diff?detail_id=105320">diff</a>)</li></ul> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1086362022-12-01T15:11:45ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/108636/diff?detail_id=105321">diff</a>)</li></ul> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1086372022-12-01T15:12:21ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/108637/diff?detail_id=105322">diff</a>)</li></ul> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1087692022-12-06T19:05:06ZTom Cleggtom@curii.com
<ul><li><strong>Story points</strong> set to <i>0.5</i></li></ul> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1088782022-12-07T17:10:55ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Tom Clegg</i></li></ul> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1089482022-12-08T20:59:49ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1089502022-12-08T21:15:07ZTom Cleggtom@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-3 priority-4 priority-default closed parent" href="/issues/8333">Feature #8333</a>: [SDKs] `arv keep docker` supports `repo:tag` image name scheme</i> added</li></ul> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1089512022-12-08T22:28:27ZTom Cleggtom@curii.com
<ul></ul>This bug was mostly fixed in <a class="issue tracker-2 status-3 priority-4 priority-default closed parent" title="Feature: [SDKs] `arv keep docker` supports `repo:tag` image name scheme (Resolved)" href="https://dev.arvados.org/issues/8333">#8333</a>, but
<ul>
<li>when listing/searching images already stored in Keep, <code>host:port/repo:tag</code> was still being split as <code>("host", "port/repo:tag")</code>, so the list output was wrong and upload would always re-upload even if the same image had already been uploaded.</li>
<li>when the explicit port happens to be <code>443</code>, docker strips it off because it's redundant in an https url -- so after <code>docker pull h:443/r:t</code> succeeds, <code>docker inspect h/r:t</code> succeeds but <code>docker inspect h:443/r:t</code> fails. Since <code>arv-keepdocker</code> was doing the latter, it would always fail to save the image after pulling.</li>
</ul>
<p>Fixed both issues and added tests.</p>
<p>19840-docker-port-number @ <a class="changeset" title="19840: Test listing saved images with names containing port numbers. Arvados-DCO-1.1-Signed-off-..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/ed948e5ff97e22594d54845097dbea77048aa2fc">ed948e5ff97e22594d54845097dbea77048aa2fc</a> -- <a class="external" href="https://ci.arvados.org/job/developer-run-tests/3409/"<a href="https://ci.arvados.org/job/developer-run-tests/3409/">developer-run-tests: #3409 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=3409" alt="" /></a></a></p> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1089532022-12-09T14:31:46ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>This LGTM, thanks.</p> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1089832022-12-09T21:09:05ZTom Cleggtom@curii.com
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '19840-docker-port-number' fixes #19840 Arvados-DCO-1.1-Signed-off-by: Tom Clegg <..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/a46c78bdc3c2136236e6fff2e17b32d3c78ca772">arvados|a46c78bdc3c2136236e6fff2e17b32d3c78ca772</a>.</p> Arvados - Bug #19840: Gets confused by port numbers in docker image namehttps://dev.arvados.org/issues/19840?journal_id=1090832022-12-13T15:32:30ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>47</i></li></ul>