Actions
Bug #19900
closed
Unhandled 404 on process details page
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
01/25/2023
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
0.5
Updated by Stephen Smith 3 months ago
Changes at arvados-workbench2|be74aae5535a64c58d408d0345b0aae94758f983
Tests developer-tests-workbench2: #1049
- Added flag to hide errors when fetching supplemental process details, output collections, container record, runtime user details
Updated by Peter Amstutz 2 months ago
- Target version changed from 2023-01-18 sprint to 2023-02-01 sprint
Updated by Peter Amstutz about 2 months ago
Stephen Smith wrote in #note-1:
Changes at arvados-workbench2|be74aae5535a64c58d408d0345b0aae94758f983
Tests developer-tests-workbench2: #1049
- Added flag to hide errors when fetching supplemental process details, output collections, container record, runtime user details
Just curious, if the request fails, is it raising an exception from loadProcess or returning null?
Otherwise, this LGTM.
Updated by Stephen Smith about 2 months ago
I actually realized I missed the exception that gets thrown as well since showErrors=false doesn't suppress that.
- I added try/catch around the supplemental requests to avoid the unhandled exception in development. In the error case, the returned value will just omit the container if it failed to load.
- If the process is not found, the not found popup still shows but the exception is caught
Changes at arvados-workbench2|38db7657138744ed97b924bc3396a1ec00de9be3
Tests developer-tests-workbench2: #1066
Updated by Peter Amstutz about 2 months ago
- Target version changed from 2023-02-01 sprint to 2023-02-15 sprint
Updated by Stephen Smith about 2 months ago
- Status changed from In Progress to Resolved
Actions