Project

General

Profile

Actions

Bug #19900

closed

Unhandled 404 on process details page

Added by Stephen Smith over 1 year ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
0.5
Release relationship:
Auto


Subtasks 1 (0 open1 closed)

Arvados - Task #19901: Review 19900-process-404-handlingResolvedPeter Amstutz01/25/2023Actions

Related issues

Has duplicate Arvados - Bug #20135: "Not Found" error modal when you view a Playground processDuplicateActions
Actions #1

Updated by Stephen Smith over 1 year ago

Changes at arvados-workbench2|be74aae5535a64c58d408d0345b0aae94758f983
Tests developer-tests-workbench2: #1049

  • Added flag to hide errors when fetching supplemental process details, output collections, container record, runtime user details
Actions #2

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2023-01-18 sprint to 2023-02-01 sprint
Actions #3

Updated by Peter Amstutz over 1 year ago

Stephen Smith wrote in #note-1:

Changes at arvados-workbench2|be74aae5535a64c58d408d0345b0aae94758f983
Tests developer-tests-workbench2: #1049

  • Added flag to hide errors when fetching supplemental process details, output collections, container record, runtime user details

Just curious, if the request fails, is it raising an exception from loadProcess or returning null?

Otherwise, this LGTM.

Actions #4

Updated by Stephen Smith over 1 year ago

I actually realized I missed the exception that gets thrown as well since showErrors=false doesn't suppress that.

  • I added try/catch around the supplemental requests to avoid the unhandled exception in development. In the error case, the returned value will just omit the container if it failed to load.
  • If the process is not found, the not found popup still shows but the exception is caught

Changes at arvados-workbench2|38db7657138744ed97b924bc3396a1ec00de9be3
Tests developer-tests-workbench2: #1066

Actions #5

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2023-02-01 sprint to 2023-02-15 sprint
Actions #6

Updated by Stephen Smith over 1 year ago

  • Status changed from In Progress to Resolved
Actions #7

Updated by Brett Smith over 1 year ago

  • Has duplicate Bug #20135: "Not Found" error modal when you view a Playground process added
Actions #8

Updated by Peter Amstutz 3 months ago

  • Release set to 57
Actions

Also available in: Atom PDF