Project

General

Profile

Actions

Feature #19970

open

a-c-r should refuse to run if git has locally modified files

Added by Peter Amstutz 5 days ago. Updated 3 days ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
CWL
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Story points:
0.5

Description

Users don't always commit their git repo before trying to run it, which makes the git tracking information less useful. It should refuse to run by default if "git status" is non-empty. Possibly with an option to override it.

Actions #1

Updated by Peter Amstutz 5 days ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 5 days ago

  • Subject changed from a-c-r refuse to run if git has locally modified files to a-c-r should refuse to run if git has locally modified files
Actions #3

Updated by Brett Smith 4 days ago

  • Story points set to 0.5

Seems straightforward, arvados_cwl.executor.ArvCwlExecutor.arv_executor already starts by collecting Git status, then goes on to do command line validation. A check could be added in that section with all the information it needs.

It would be nice to specify an exit code for this situation but this function is just raising a plain Exception for all command line errors like this so we'll do the same here.

Propose to name the flag --allow-uncommitted.

Actions #4

Updated by Peter Amstutz 3 days ago

  • Target version changed from To be groomed to To be scheduled
Actions

Also available in: Atom PDF