Project

General

Profile

Actions
Copy link

Bug #19976

open

Better error when 'location' is not a string

Added by Peter Amstutz over 1 year ago. Updated about 1 year ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
CWL
Target version:
Future
Story points:
-

Description

When a 'location' field in the input in not a string, it will fail with an error like

AttributeError: 'CommentedSeq' object has no attribute 'split'

It should explicitly check that 'location' is a string and report a more meaningful error.

Most of the code here is actually in cwltool so that might be a better place to fix it.

Files

Download all files
cat.cwl (141 Bytes) cat.cwl Brett Smith, 01/24/2023 10:09 PM
cat-params.yml (38 Bytes) cat-params.yml Brett Smith, 01/24/2023 10:09 PM
Actions
Copy link
 #1

Updated by Peter Amstutz over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Brett Smith about 1 year ago

cwltool has almost the exact same problem, at least as of 3.1.20221201130942:

$ cwltool cat.cwl cat-params.yml
INFO /opt/arvados/arvenv/bin/cwltool 3.1.20221201130942
INFO Resolved 'cat.cwl' to 'file:///home/brett/Curii/Notes/cat.cwl'
ERROR Unhandled error, try again with --debug for more information:
  'int' object has no attribute 'startswith'

It seems to validate input CWL with salad-schema. Does it not do the same for input parameters? If that's doable it seems like it would be the ideal fix.

Actions
Copy link

Also available in: Atom PDF