Project

General

Profile

Actions

Story #19977

open

Update tests to run with a strict vocabulary

Added by Brett Smith 4 days ago. Updated 4 days ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
Tests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Story points:
1.0

Description

  • Write a vocubalary.json for the tests in the right place (FIXME: where is that?). It should define at least a couple of tags and "strict_tags": true.
  • Update the test configuration in run_test_server.py to set API.VocabularyPath to that file path.
  • Update tests broken by this change to continue passing while exercising the same behavior as before.

We want to make this change to help us catch system tags that we add without documentation or adding them to systemTagKeys in vocabulary.go.


Files

Actions #1

Updated by Brett Smith 4 days ago

I made a throwaway branch to define a strict vocabulary for the tests and run that on Jenkins to see how much effort would be involved. I just used the example vocabulary from our documentation, with strict_tags set true. I've attached the logs from all failing tests.

As far as I can tell, all of these are little one-offs that are just checking property propagation generally, and it would be no problem to update them to use properties defined in our test vocabulary. s3_test.go records a lot of failures, but that's because the property is in a common fixture and checked on every test. We just need to update one fixture and one assertion to get them all passing again.

Actions #2

Updated by Brett Smith 4 days ago

  • Target version set to To be groomed
Actions

Also available in: Atom PDF