Project

General

Profile

Actions
Copy link

Bug #20000

closed

Cancel button missing in "Queued" state

Added by Peter Amstutz almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Stephen Smith
Category:
Workbench2
Target version:
2023-03-01 sprint
Story points:
1.0
Release:
Arvados 2.6.0
Release relationship:
Auto

Files

button-flickering.mov (4.2 MB) button-flickering.mov Lucas Di Pentima, 02/16/2023 03:48 PM

Subtasks 1 (0 open — 1 closed)

Task #20046: Review 20000-process-cancel-buttonResolvedLucas Di Pentima02/15/2023Actions

Related issues

Related to Arvados Workbench 2 - Bug #19517: Can't find the button to kill a wf running in wb2NewActions
Actions
Copy link
 #2

Updated by Lucas Di Pentima almost 2 years ago

  • Story points set to 1.0

Actual fix should be fairly trivial, but writing proper tests might take some effort.

Actions
Copy link
 #3

Updated by Peter Amstutz almost 2 years ago

  • Target version changed from Future to To be scheduled
Actions
Copy link
 #4

Updated by Peter Amstutz almost 2 years ago

  • Target version changed from To be scheduled to 2023-02-15 sprint
Actions
Copy link
 #5

Updated by Peter Amstutz almost 2 years ago

  • Assigned To set to Stephen Smith
Actions
Copy link
 #6

Updated by Sarah Zaranek almost 2 years ago

This is also related to this ticket:
https://dev.arvados.org/issues/19517

Actions
Copy link
 #7

Updated by Sarah Zaranek almost 2 years ago

  • Related to Bug #19517: Can't find the button to kill a wf running in wb2 added
Actions
Copy link
 #8

Updated by Stephen Smith almost 2 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #9

Updated by Peter Amstutz almost 2 years ago

  • Release set to 57
Actions
Copy link
 #10

Updated by Peter Amstutz almost 2 years ago

  • Target version changed from 2023-02-15 sprint to 2023-03-01 sprint
Actions
Copy link
 #11

Updated by Stephen Smith almost 2 years ago

Changes at arvados-workbench2|4968c1548af68dde9760766f6f0db667edaae7de
Tests developer-tests-workbench2: #1083

  • Show cancel button on queued and locked processes
  • Show run button to resume cancelled processes
  • Change run button to default button color, rename to "Run"
  • Add tests to verify cancel/run shows in appropriate scenario
Actions
Copy link
 #12

Updated by Lucas Di Pentima almost 2 years ago

Some comments and questions:

  • I tried it on tordo and I'm seeing some button flickering when cancelling a running process and state changes.
    • For example, the RUN button and the "Running" label both appears at the same time for a moment.
    • I think these behaviors will be confusing for users.
  • As you can see in the attached ideo, the cancelled process doesn't get the RUN button at its final state.
  • Can we style the "Cancel" button the same way as the "Run" button?
Actions
Copy link
 #13

Updated by Stephen Smith almost 2 years ago

Changes at arvados-workbench2|10d5becc49f4b673d3abfbe8ea9d5f253a24f08b
Tests developer-tests-workbench2: #1092

  • Reduce flickering by reloading container when container request is updated and by hiding the run button in cases where the container is transitioning between states
  • Change cancel button to outlined button
Actions
Copy link
 #14

Updated by Lucas Di Pentima almost 2 years ago

Great improvements! LGTM, thanks.

Actions
Copy link
 #15

Updated by Stephen Smith almost 2 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF