Bug #20264: "invalid return_to parameter: requesting site is not listed in TrustedClients config" on logout - Arvados

Actions

Copy link

Bug #20264

closed

"invalid return_to parameter: requesting site is not listed in TrustedClients config" on logout

Added by Peter Amstutz over 1 year ago. Updated over 1 year ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Tom Clegg

Category:

API

Target version:

Development 2023-04-12 sprint

Story points:

Release:

Arvados 2.6.0

Release relationship:

Auto

Description

When I get sent to the logout endpoint, I get this error

{"errors":["invalid return_to parameter: requesting site is not listed in TrustedClients config"]}

I think this is a bug in the log out process because it happens on clusters where I was able to log in. It's annoying.

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Peter Amstutz over 1 year ago

Description updated (diff)

Actions

Copy link

Updated by Tom Clegg over 1 year ago

Suspect this is happening because config Workbench2.ExternalURL has a redundant ":443". The validation in source:lib/controller/localdb/login.go does this:

        u, err = u.Parse("/")
        if err != nil {
                return err
        }
        if u.Port() == "80" && u.Scheme == "http" {
                u.Host = u.Hostname()
        } else if u.Port() == "443" && u.Scheme == "https" {
                u.Host = u.Hostname()
        }
        if _, ok := cluster.Login.TrustedClients[arvados.URL(*u)]; ok {
                return nil
        }
        if u.String() == cluster.Services.Workbench1.ExternalURL.String() ||
                u.String() == cluster.Services.Workbench2.ExternalURL.String() {
                return nil
        }