Arvados

Suspect this is happening because config Workbench2.ExternalURL has a redundant ":443". The validation in source:lib/controller/localdb/login.go does this:

        u, err = u.Parse("/")
        if err != nil {
                return err
        }
        if u.Port() == "80" && u.Scheme == "http" {
                u.Host = u.Hostname()
        } else if u.Port() == "443" && u.Scheme == "https" {
                u.Host = u.Hostname()
        }
        if _, ok := cluster.Login.TrustedClients[arvados.URL(*u)]; ok {
                return nil
        }
        if u.String() == cluster.Services.Workbench1.ExternalURL.String() ||
                u.String() == cluster.Services.Workbench2.ExternalURL.String() {
                return nil
        }

This should also strip redundant :443 and :80 from the config ExternalURL values too before doing the comparison.

20264-trusted-clients-portnumber @ 2bc1519df3f1995c852cf9bfba6e85ebd0f33c84 -- developer-run-tests: #3568

Tom Clegg wrote in #note-6:

20264-trusted-clients-portnumber @ 2bc1519df3f1995c852cf9bfba6e85ebd0f33c84 -- developer-run-tests: #3568

This LGTM.