Project

General

Profile

Actions

Feature #20382

closed

Process/subprocess action menu should include "Cancel"

Added by Peter Amstutz 12 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
0.5

Files

20382passing.png (116 KB) 20382passing.png Lisa Knox, 10/19/2023 05:50 PM

Subtasks 1 (0 open1 closed)

Task #20442: Review 20382-process-action-menu-cancelResolvedStephen Smith10/19/2023Actions
Actions #1

Updated by Peter Amstutz 12 months ago

  • Target version changed from Development 2023-04-26 sprint to Development 2023-05-10 sprint
Actions #2

Updated by Peter Amstutz 12 months ago

  • Story points set to 0.5
Actions #3

Updated by Peter Amstutz 12 months ago

  • Assigned To set to Lisa Knox
Actions #4

Updated by Peter Amstutz 11 months ago

  • Target version changed from Development 2023-05-10 sprint to Development 2023-05-24 sprint
Actions #5

Updated by Peter Amstutz 11 months ago

  • Target version changed from Development 2023-05-24 sprint to To be scheduled
Actions #6

Updated by Peter Amstutz 8 months ago

  • Target version changed from To be scheduled to Development 2023-08-30
Actions #7

Updated by Peter Amstutz 8 months ago

  • Target version changed from Development 2023-08-30 to Development 2023-09-13 sprint
Actions #8

Updated by Peter Amstutz 8 months ago

  • Target version changed from Development 2023-09-13 sprint to Development 2023-09-27 sprint
Actions #9

Updated by Peter Amstutz 7 months ago

  • Target version changed from Development 2023-09-27 sprint to Development 2023-10-11 sprint
Actions #10

Updated by Lisa Knox 7 months ago

  • Status changed from New to In Progress
Actions #11

Updated by Lisa Knox 7 months ago

All items finished - Waiting for cypress fixes in 15768 to be merged.

Actions #12

Updated by Peter Amstutz 6 months ago

  • Target version changed from Development 2023-10-11 sprint to Development 2023-10-25 sprint
Actions #13

Updated by Peter Amstutz 6 months ago

  • Tracker changed from Bug to Feature
Actions #14

Updated by Lisa Knox 6 months ago

20382-process-action-menu-cancel @ commit: 92eefe98ca9631ee971881fc46f8a1829ac897b9

  • All agreed upon points are implemented / addressed.
    • done
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • all tests pass locally, see attached screenshot
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • n/a
  • Considered backwards and forwards compatibility issues between client and server.
    • no considerations necessary
  • Follows our coding standards and GUI style guidelines.
    • done
Actions #15

Updated by Stephen Smith 6 months ago

A couple improvement ideas but otherwise LGTM:

  • Instead of making a separate openRunningProcessContextMenu and doing checks with isProcessCancelable in multiple places, since the resource is available inside openProcessContextMenu you can probably just replace the menuKind: ContextMenuKind.PROCESS_RESOURCE in openProcessContextMenu with menuKind: isProcessCancelable(res) ? ContextMenuKind.RUNNING_PROCESS_RESOURCE : ContextMenuKind.PROCESS_RESOURCE, that way every consumer of openProcessContextMenu doesn't need to do the check
  • I think it would be nice to dedupe the action definitions for Cancel and Public Favorites in process-resource-action-set.ts, maybe just a separate non-exported const processCancelAction: ContextMenuAction and similar for the public favorites action would do the trick so that they're not defined twice
Actions #16

Updated by Lisa Knox 6 months ago

Done and done!

Actions #17

Updated by Lisa Knox 6 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF