Actions
Feature #20382
closedProcess/subprocess action menu should include "Cancel"
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
0.5
Release:
Release relationship:
Auto
Files
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-04-26 sprint to Development 2023-05-10 sprint
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-05-10 sprint to Development 2023-05-24 sprint
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-05-24 sprint to To be scheduled
Updated by Peter Amstutz about 1 year ago
- Target version changed from To be scheduled to Development 2023-08-30
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-08-30 to Development 2023-09-13 sprint
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-09-13 sprint to Development 2023-09-27 sprint
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-09-27 sprint to Development 2023-10-11 sprint
Updated by Lisa Knox about 1 year ago
All items finished - Waiting for cypress fixes in 15768 to be merged.
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-10-11 sprint to Development 2023-10-25 sprint
Updated by Lisa Knox 12 months ago
- File 20382passing.png 20382passing.png added
20382-process-action-menu-cancel @ commit: 92eefe98ca9631ee971881fc46f8a1829ac897b9
- All agreed upon points are implemented / addressed.
- done
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- n/a
- Code is tested and passing, both automated and manual, what manual testing was done is described
- all tests pass locally, see attached screenshot
- Documentation has been updated.
- n/a
- Behaves appropriately at the intended scale (describe intended scale).
- n/a
- Considered backwards and forwards compatibility issues between client and server.
- no considerations necessary
- Follows our coding standards and GUI style guidelines.
- done
Updated by Stephen Smith 12 months ago
A couple improvement ideas but otherwise LGTM:
- Instead of making a separate
openRunningProcessContextMenu
and doing checks withisProcessCancelable
in multiple places, since the resource is available insideopenProcessContextMenu
you can probably just replace themenuKind: ContextMenuKind.PROCESS_RESOURCE
inopenProcessContextMenu
withmenuKind: isProcessCancelable(res) ? ContextMenuKind.RUNNING_PROCESS_RESOURCE : ContextMenuKind.PROCESS_RESOURCE
, that way every consumer ofopenProcessContextMenu
doesn't need to do the check - I think it would be nice to dedupe the action definitions for Cancel and Public Favorites in
process-resource-action-set.ts
, maybe just a separate non-exportedconst processCancelAction: ContextMenuAction
and similar for the public favorites action would do the trick so that they're not defined twice
Actions