Arvados

Updates at commit:8c9aa790|arvados-workbench2 - branch 20384-log-viewer-improvements
Test run: developer-tests-workbench2: #1182

• Improves message wording on log viewer from 'some log(s) were skipped' to '...not be displayed' in order to be less confusing.
• Adds a clickable link to the log collection's UUID so that the user can see the full logs there.
• Refactors the way it shows the above message to avoid some cases where it appeared as a last log message or before a handful of additional log lines: now it will be added as the first log line whenever the code detects that there're more than 1000 log objects on the API server.
• Shows the message on all filters instead of appearing on just "Main logs" and "All logs".
• Upgrades caniuse-lite package.
• Fixes some linter warnings.

Lucas Di Pentima wrote in #note-8:

Updates at commit:8c9aa790|arvados-workbench2 - branch 20384-log-viewer-improvements
Test run: developer-tests-workbench2: #1182

• Improves message wording on log viewer from 'some log(s) were skipped' to '...not be displayed' in order to be less confusing.
• Adds a clickable link to the log collection's UUID so that the user can see the full logs there.
• Refactors the way it shows the above message to avoid some cases where it appeared as a last log message or before a handful of additional log lines: now it will be added as the first log line whenever the code detects that there're more than 1000 log objects on the API server.
• Shows the message on all filters instead of appearing on just "Main logs" and "All logs".
• Upgrades caniuse-lite package.
• Fixes some linter warnings.

I don't think this actually solves the problem, though? You can still be in a situation where you loaded 1000 crunchstat logs and didn't load the one stderr log that you actually wanted to see.

Shouldn't loadContainerLogs() filter for the specific log types that are going to be displayed? I would much prefer it re-loads logs when you change which log type you are looking at -- which basically never happens because the main logs are the only ones I care about in the live log view. We could even consider getting rid of the log type selector entirely and just display the crunch-run, stdout, stderr, and dispatch log events.

From chat: We talked about making the log viewer initially request the last half hour of logs (instead of just the last 1000 logs), to make sure the user has the complete picture of logs (older than 30 minute logs should be already committed to the log collection)

Lucas Di Pentima wrote in #note-10:

From chat: We talked about making the log viewer initially request the last half hour of logs (instead of just the last 1000 logs), to make sure the user has the complete picture of logs (older than 30 minute logs should be already committed to the log collection)

The "snipped" line could also specifically say "showing last half hour of logs, for previous logs go see ..."