Idea #20384
closedLog viewer cutting events
Added by Peter Amstutz over 1 year ago. Updated about 1 year ago.
Description
- The "some logs were cut" line should
- be changed to say "some logs are not displayed"
- tell you to go to the log collection (with linked uuid) to get the full logs
- it seems a little bit buggy, where the last page is often very short (I'm expecting to get 100 or 1000 log lines/events but it only shows 10 or sometimes none)
Updated by Peter Amstutz over 1 year ago
- Subject changed from Log viewer improvements to Log viewer fixes
Updated by Peter Amstutz over 1 year ago
- Status changed from In Progress to New
- Subject changed from Log viewer fixes to Log viewer improvements
Updated by Peter Amstutz over 1 year ago
- Subject changed from Log viewer improvements to Log viewer cutting events
Updated by Peter Amstutz over 1 year ago
- Target version changed from Future to Development 2023-04-26 sprint
- Assigned To set to Lucas Di Pentima
Updated by Lucas Di Pentima over 1 year ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima over 1 year ago
Updates at commit:8c9aa790|arvados-workbench2 - branch 20384-log-viewer-improvements
Test run: developer-tests-workbench2: #1182
- Improves message wording on log viewer from 'some log(s) were skipped' to '...not be displayed' in order to be less confusing.
- Adds a clickable link to the log collection's UUID so that the user can see the full logs there.
- Refactors the way it shows the above message to avoid some cases where it appeared as a last log message or before a handful of additional log lines: now it will be added as the first log line whenever the code detects that there're more than 1000 log objects on the API server.
- Shows the message on all filters instead of appearing on just "Main logs" and "All logs".
- Upgrades
caniuse-lite
package. - Fixes some linter warnings.
Updated by Peter Amstutz over 1 year ago
Lucas Di Pentima wrote in #note-8:
Updates at commit:8c9aa790|arvados-workbench2 - branch
20384-log-viewer-improvements
Test run: developer-tests-workbench2: #1182
- Improves message wording on log viewer from 'some log(s) were skipped' to '...not be displayed' in order to be less confusing.
- Adds a clickable link to the log collection's UUID so that the user can see the full logs there.
- Refactors the way it shows the above message to avoid some cases where it appeared as a last log message or before a handful of additional log lines: now it will be added as the first log line whenever the code detects that there're more than 1000 log objects on the API server.
- Shows the message on all filters instead of appearing on just "Main logs" and "All logs".
- Upgrades
caniuse-lite
package.- Fixes some linter warnings.
I don't think this actually solves the problem, though? You can still be in a situation where you loaded 1000 crunchstat logs and didn't load the one stderr log that you actually wanted to see.
Shouldn't loadContainerLogs() filter for the specific log types that are going to be displayed? I would much prefer it re-loads logs when you change which log type you are looking at -- which basically never happens because the main logs are the only ones I care about in the live log view. We could even consider getting rid of the log type selector entirely and just display the crunch-run, stdout, stderr, and dispatch log events.
Updated by Lucas Di Pentima over 1 year ago
From chat: We talked about making the log viewer initially request the last half hour of logs (instead of just the last 1000 logs), to make sure the user has the complete picture of logs (older than 30 minute logs should be already committed to the log collection)
Updated by Peter Amstutz over 1 year ago
Lucas Di Pentima wrote in #note-10:
From chat: We talked about making the log viewer initially request the last half hour of logs (instead of just the last 1000 logs), to make sure the user has the complete picture of logs (older than 30 minute logs should be already committed to the log collection)
The "snipped" line could also specifically say "showing last half hour of logs, for previous logs go see ..."
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-04-26 sprint to Development 2023-05-10 sprint
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-05-10 sprint to Development 2023-05-24 sprint
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-05-24 sprint to Development 2023-06-07
Updated by Peter Amstutz over 1 year ago
- Target version changed from Development 2023-06-07 to To be scheduled
Updated by Lucas Di Pentima about 1 year ago
- Assigned To deleted (
Lucas Di Pentima)
Updated by Peter Amstutz about 1 year ago
- Status changed from In Progress to Closed
Closing because this will be obsolete by new log system (which may have its own log trimming behavior but the implementation/behavior will be different).
Updated by Peter Amstutz about 1 year ago
- Target version deleted (
To be scheduled)