Project

General

Profile

Actions

Feature #20433

closed

Config option to have crunch-run stop sending logs to logs table

Added by Peter Amstutz 10 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Start date:
05/31/2023
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #20443: Review 20433-crunch-log-zero-bytes-jobResolvedBrett Smith05/31/2023

Actions

Related issues

Related to Arvados Epics - Story #16442: Scalable + reliable container loggingResolved03/15/202308/31/2023

Actions
Actions #1

Updated by Peter Amstutz 10 months ago

  • Target version changed from To be groomed to Development 2023-05-10 sprint
Actions #2

Updated by Peter Amstutz 10 months ago

  • Story points set to 0.5
  • Assigned To set to Tom Clegg
  • Category set to Crunch
Actions #3

Updated by Tom Clegg 10 months ago

  • Related to Story #16442: Scalable + reliable container logging added
Actions #4

Updated by Peter Amstutz 10 months ago

  • Assigned To changed from Tom Clegg to Brett Smith
Actions #5

Updated by Tom Clegg 10 months ago

We already have this

        # Maximum bytes that may be logged by a single job.  Log bytes that are                                                                                             
        # silenced by throttling are not counted against this total.                                                                                                        
        LimitLogBytesPerJob: 67108864

Perhaps we just need to ensure (and document) that setting this to 0 disables all the "create log" API calls (rather than meaning "unlimited").

Actions #6

Updated by Peter Amstutz 10 months ago

  • Target version changed from Development 2023-05-10 sprint to Development 2023-05-24 sprint
Actions #7

Updated by Peter Amstutz 10 months ago

  • Target version changed from Development 2023-05-24 sprint to Development 2023-06-07
Actions #8

Updated by Brett Smith 9 months ago

20433-crunch-log-zero-bytes-job @ f4cb9b474add3becb58dccaf555c2a52d15cbd27 - developer-run-tests: #3682

This branch does the bare minimum of testing the specific case where LimitLogBytesPerJob=0 and documenting the behavior. Note that in this case the container still creates a single log record noting that the throttle is in effect. I do think we should leave this as an affordance so users don't wonder why their Workbench log viewer is empty if they see that.

There are various things we could do to make this more user-friendly, but I assume none of them are worth time or effort given the plan to replace this system completely in the short-to-medium term.

Actions #9

Updated by Tom Clegg 9 months ago

Agree on both points.

LGTM, thanks.

Actions #10

Updated by Brett Smith 9 months ago

  • Status changed from New to Resolved
Actions #11

Updated by Peter Amstutz 9 months ago

  • Release set to 64
Actions

Also available in: Atom PDF