Feature #20433
closed
- Target version changed from Future to Development 2023-05-10 sprint
- Story points set to 0.5
- Assigned To set to Tom Clegg
- Category set to Crunch
- Related to Idea #16442: Scalable + reliable container logging added
- Assigned To changed from Tom Clegg to Brett Smith
We already have this
# Maximum bytes that may be logged by a single job. Log bytes that are
# silenced by throttling are not counted against this total.
LimitLogBytesPerJob: 67108864
Perhaps we just need to ensure (and document) that setting this to 0 disables all the "create log" API calls (rather than meaning "unlimited").
- Target version changed from Development 2023-05-10 sprint to Development 2023-05-24 sprint
- Target version changed from Development 2023-05-24 sprint to Development 2023-06-07
20433-crunch-log-zero-bytes-job @ f4cb9b474add3becb58dccaf555c2a52d15cbd27 - developer-run-tests: #3682
This branch does the bare minimum of testing the specific case where LimitLogBytesPerJob=0
and documenting the behavior. Note that in this case the container still creates a single log record noting that the throttle is in effect. I do think we should leave this as an affordance so users don't wonder why their Workbench log viewer is empty if they see that.
There are various things we could do to make this more user-friendly, but I assume none of them are worth time or effort given the plan to replace this system completely in the short-to-medium term.
Agree on both points.
LGTM, thanks.
- Status changed from New to Resolved
Also available in: Atom
PDF