Project

General

Profile

Actions

Bug #20455

closed

Add rel=”noopener” to anywhere we use target="_blank"

Added by Peter Amstutz about 1 year ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release relationship:
Auto

Description

When using target="_blank" the new tab will have a relationship with the original tab, in fact they will share the same Javascript context (!). This means the tabs can interfere each other -- if something on one tab is slow or memory hungry it can crash all the other tabs it is connected to by the "open in new tab" behavior.

Adding rel="noopener" prevents that behavior.

(on further research, it seems some browsers now set this by default as a security measure, but we should be explicit about it).


Subtasks 1 (0 open1 closed)

Task #21558: Review 20455-noopenerResolvedPeter Amstutz03/18/2024Actions
Actions #1

Updated by Peter Amstutz about 1 year ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz about 1 year ago

  • Release set to 63
Actions #3

Updated by Peter Amstutz about 1 year ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz about 1 year ago

  • Release deleted (63)
Actions #5

Updated by Peter Amstutz 4 months ago

  • Target version changed from Future to Development 2024-03-13 sprint
Actions #6

Updated by Peter Amstutz 4 months ago

  • Assigned To set to Peter Amstutz
Actions #7

Updated by Peter Amstutz 3 months ago

  • Release set to 69
Actions #8

Updated by Peter Amstutz 3 months ago

20455-noopener @ 2aff408211e84a226af6f74cb9338cbaf3fc4645

It was used in a bunch of places already but not everywhere.

I removed "noreferrer" as this does something different (it prevents
passing the "Referer" header when opening the new URL). It's not
clear users benefits from suppressing the information that they
navigated to a link from workbench.

developer-run-tests: #4066

Actions #9

Updated by Peter Amstutz 3 months ago

  • Status changed from New to In Progress
Actions #10

Updated by Lisa Knox 3 months ago

LGTM

Actions #11

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-03-13 sprint to Development 2024-03-27 sprint
Actions #12

Updated by Peter Amstutz 3 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF