Arvados

20462-workflow-prefix @ 7ac1e7337dca972ce93d04e5eccb6f4de9aed141

developer-run-tests: #3626

Would you accept this implementation that's O(n) instead of O(n²)? It passes all your tests.

def common_prefix(firstfile, all_files):
    common_parts = firstfile.split('/')
    common_parts[-1] = ''
    for f in all_files:
        f_parts = f.split('/')
        for index, (a, b) in enumerate(zip(common_parts, f_parts)):
            if a != b:
                common_parts = common_parts[:index + 1]
                common_parts[-1] = ''
                break
        if not any(common_parts):
            break
    return '/'.join(common_parts)

It seems like this function should be defined in cwl.util. That's where you wrote the tests, and multiple modules are using it, and it's just a generic string manipulation function. How about moving it?

Brett Smith wrote in #note-4:

Would you accept this implementation that's O(n) instead of O(n²)? It passes all your tests.

[...]

This feels a bit like code golf but sure, I can use your implementation.

It seems like this function should be defined in cwl.util. That's where you wrote the tests, and multiple modules are using it, and it's just a generic string manipulation function. How about moving it?

Sure.