Project

General

Profile

Actions

Feature #20522

closed

Option to load private key from specified file instead of inline in config file

Added by Tom Clegg 11 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Story points:
0.5
Release relationship:
Auto

Description

If the Containers.DispatchPrivateKey config value starts with file://, it indicates a local file or FIFO from which the private key should be retrieved.


Subtasks 1 (0 open1 closed)

Task #20551: Review 20522-load-dispatch-priv-keyResolvedTom Clegg06/05/2023Actions
Actions #1

Updated by Tom Clegg 11 months ago

  • Assigned To set to Tom Clegg
  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz 11 months ago

  • Target version changed from To be scheduled to Development 2023-06-07
Actions #5

Updated by Brett Smith 10 months ago

Tom Clegg wrote in #note-4:

20522-load-dispatch-priv-key @ 4d095628f05fae2d2609b91dc12d0f44434b8aa2 -- developer-run-tests: #3657

My only comment is I don't understand why the new mutex lock in KillInstance is part of this branch. If there's some deep reason why reading an SSH key from the filesystem might require this, a comment might be helpful for future developers, in case they're only thinking about the key-in-config path. If it's just a bugfix that you happened to notice while you working on this, eh, whatever. Either way, this is good to merge, thanks.

Actions #6

Updated by Tom Clegg 10 months ago

Brett Smith wrote in #note-5:

My only comment is I don't understand why the new mutex lock in KillInstance is part of this branch.

Oops, I should have put that in a separate commit. Yes, it was just an unrelated bug I happened to spy while working on this.

Actions #7

Updated by Tom Clegg 10 months ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Peter Amstutz 10 months ago

  • Release set to 64
Actions

Also available in: Atom PDF