Feature #20522
closed
Option to load private key from specified file instead of inline in config file
Description
If the Containers.DispatchPrivateKey config value starts with file://, it indicates a local file or FIFO from which the private key should be retrieved.
Updated by Tom Clegg over 1 year ago
- Assigned To set to Tom Clegg
- Status changed from New to In Progress
Updated by Peter Amstutz over 1 year ago
- Target version changed from To be scheduled to Development 2023-06-07
Updated by Tom Clegg over 1 year ago
20522-load-dispatch-priv-key @ 4d095628f05fae2d2609b91dc12d0f44434b8aa2 -- developer-run-tests: #3657
Updated by Brett Smith over 1 year ago
Tom Clegg wrote in #note-4:
20522-load-dispatch-priv-key @ 4d095628f05fae2d2609b91dc12d0f44434b8aa2 -- developer-run-tests: #3657
My only comment is I don't understand why the new mutex lock in KillInstance is part of this branch. If there's some deep reason why reading an SSH key from the filesystem might require this, a comment might be helpful for future developers, in case they're only thinking about the key-in-config path. If it's just a bugfix that you happened to notice while you working on this, eh, whatever. Either way, this is good to merge, thanks.
Updated by Tom Clegg over 1 year ago
Brett Smith wrote in #note-5:
My only comment is I don't understand why the new mutex lock in
KillInstanceis part of this branch.
Oops, I should have put that in a separate commit. Yes, it was just an unrelated bug I happened to spy while working on this.
Updated by Tom Clegg over 1 year ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|cc1c83c261d289c7fa049637f8ae1fabe352059c.