Feature #20522: Option to load private key from specified file instead of inline in config file - Arvados

Actions

Copy link

Feature #20522

closed

Option to load private key from specified file instead of inline in config file

Added by Tom Clegg 11 months ago. Updated 11 months ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Tom Clegg

Category:

Crunch

Target version:

Development 2023-06-07

Story points:

0.5

Release:

Arvados 2.6.3

Release relationship:

Auto

Description

If the Containers.DispatchPrivateKey config value starts with file://, it indicates a local file or FIFO from which the private key should be retrieved.

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Tom Clegg 11 months ago

Assigned To set to Tom Clegg
Status changed from New to In Progress

Actions

Copy link

Updated by Peter Amstutz 11 months ago

Target version changed from To be scheduled to Development 2023-06-07

Actions

Copy link

Updated by Tom Clegg 11 months ago

20522-load-dispatch-priv-key @ 4d095628f05fae2d2609b91dc12d0f44434b8aa2 -- developer-run-tests: #3657

Actions

Copy link

Updated by Brett Smith 11 months ago

Tom Clegg wrote in #note-4:

20522-load-dispatch-priv-key @ 4d095628f05fae2d2609b91dc12d0f44434b8aa2 -- developer-run-tests: #3657

My only comment is I don't understand why the new mutex lock in KillInstance is part of this branch. If there's some deep reason why reading an SSH key from the filesystem might require this, a comment might be helpful for future developers, in case they're only thinking about the key-in-config path. If it's just a bugfix that you happened to notice while you working on this, eh, whatever. Either way, this is good to merge, thanks.

Actions

Copy link