Arvados

Changes at arvados-workbench2|dcf2e835b33e926073dad1f636cf92a95493ca0b branch 20609-subprocess-progress-bar
Tests developer-tests-workbench2: #1390

• All agreed upon points are implemented / addressed.
  • Add bootstrap/coreui for segmented progress bar
  • Upgrade node/node-dom to 16.14 in order to unit test useEffect
  • Place progress bar between subprocess title and headermenu, move multiselect toolbar to below titlebar when there is a panel title or progress bar
  • Add support for multiple statuses combined in segments, onhold displays with queued, cancelled displays with failed
  • Update caniuse and momentjs
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • Added unit tests for progress bar and tested to ensure it creates the correct filters for each segment and correctly combines the right statuses
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • Shouldn't be impacted by scale, the status requests use limit:0 to only retrieve the count of subprocesses with the matching status
• Considered backwards and forwards compatibility issues between client and server.
  • n/a
• Follows our coding standards and GUI style guidelines.
  • Space is tight in the title bar so the best I think I can do is tooltips with the status and count

Stephen Smith wrote in #note-24:

Changes at arvados-workbench2|dcf2e835b33e926073dad1f636cf92a95493ca0b branch 20609-subprocess-progress-bar
Tests developer-tests-workbench2: #1390

• All agreed upon points are implemented / addressed.
  • Add bootstrap/coreui for segmented progress bar
  • Upgrade node/node-dom to 16.14 in order to unit test useEffect
  • Place progress bar between subprocess title and headermenu, move multiselect toolbar to below titlebar when there is a panel title or progress bar
  • Add support for multiple statuses combined in segments, onhold displays with queued, cancelled displays with failed
  • Update caniuse and momentjs
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • Added unit tests for progress bar and tested to ensure it creates the correct filters for each segment and correctly combines the right statuses
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • Shouldn't be impacted by scale, the status requests use limit:0 to only retrieve the count of subprocesses with the matching status
• Considered backwards and forwards compatibility issues between client and server.
  • n/a
• Follows our coding standards and GUI style guidelines.
  • Space is tight in the title bar so the best I think I can do is tooltips with the status and count

Couple thoughts:

• If you push the bar down by changing the progressWrapper top margin from 25px to 30px, the lower line of the progress bar more or less aligns with the baseline of the title text to the left, which I think looks a bit better than floating vertically not clearly aligned with anything.
• It's updating the progress bar independently of updating the subprocess listing, which can result in them being out of sync, e.g. the listing is empty but the bar shows several items. It should update both on the same trigger (whether that is polling or websockets).