Project

General

Profile

Actions

Feature #20609

closed

Progress bar showing state of subprocesses

Added by Peter Amstutz 9 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
1.0
Release relationship:
Auto

Description

SWZ: In WB1 there is the ability to see the status of my entire job easily (i.e. 210 containers, 209 success, 1 running, etc,) it is really hard to tell the state of a long job running without this. Is it possible to have this feature back?

PA: Are you basically just looking for a summary count of queued/running/completed/failed?

TC: I think a little progress bar with color sections for each status, and the #s beside, would go a long way

Could look something like this:

Progress bar with each section taking up its % of total (green/white with green outline/red/grey) (white with green outline for "running" could also have green diagonal stripes)

[Completed][Running][Failed][Queued]

With a numeric summary underneath:

Completed: 123 Running: 45 Failed: 6 Queued: 789 Total: 963

Similar request from user:

Hi, would it be possible/helpful to add a small section/indication/tracker at the top to the UI indicating how many subprocesses failed and/or completed within a particular run of the workflow? For e.g. in this workflow run (...), 19 samples completed and 1 failed. It would be good to know at the top of the page as a summary. Just a thought. Thank you.

note: from discussion, we can already filter by container state, see workbench2/src/store/resource-type-filters/resource-type-filters.ts


Subtasks 1 (0 open1 closed)

Task #20911: Review 20609-subprocess-progress-barResolvedStephen Smith11/14/2023Actions
Actions #1

Updated by Peter Amstutz 9 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 9 months ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz 9 months ago

  • Description updated (diff)
Actions #5

Updated by Peter Amstutz 9 months ago

  • Description updated (diff)
Actions #6

Updated by Peter Amstutz 8 months ago

  • Story points set to 1.0
Actions #7

Updated by Peter Amstutz 8 months ago

  • Description updated (diff)
Actions #8

Updated by Peter Amstutz 8 months ago

  • Target version changed from To be groomed to Development 2023-07-05 sprint
Actions #9

Updated by Peter Amstutz 8 months ago

  • Target version changed from Development 2023-07-05 sprint to Development 2023-07-19 sprint
Actions #10

Updated by Peter Amstutz 8 months ago

  • Target version changed from Development 2023-07-19 sprint to Development 2023-08-02 sprint
Actions #11

Updated by Peter Amstutz 8 months ago

  • Target version changed from Development 2023-08-02 sprint to Development 2023-08-16
Actions #12

Updated by Peter Amstutz 7 months ago

  • Target version changed from Development 2023-08-16 to Development 2023-08-30
Actions #13

Updated by Peter Amstutz 7 months ago

  • Target version changed from Development 2023-08-30 to Development 2023-09-13 sprint
Actions #14

Updated by Peter Amstutz 6 months ago

  • Target version changed from Development 2023-09-13 sprint to Development 2023-09-27 sprint
Actions #15

Updated by Peter Amstutz 6 months ago

  • Target version changed from Development 2023-09-27 sprint to Development 2023-09-13 sprint
Actions #16

Updated by Stephen Smith 6 months ago

  • Assigned To set to Stephen Smith
Actions #17

Updated by Peter Amstutz 6 months ago

  • Target version changed from Development 2023-09-13 sprint to Development 2023-09-27 sprint
Actions #18

Updated by Stephen Smith 5 months ago

  • Status changed from New to In Progress
Actions #19

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2023-09-27 sprint to Development 2023-10-11 sprint
Actions #20

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2023-10-11 sprint to Development 2023-10-25 sprint
Actions #21

Updated by Peter Amstutz 5 months ago

  • Release set to 67
Actions #22

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2023-10-25 sprint to Development 2023-11-08 sprint
Actions #23

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2023-11-08 sprint to Development 2023-11-29 sprint
Actions #24

Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|dcf2e835b33e926073dad1f636cf92a95493ca0b branch 20609-subprocess-progress-bar
Tests developer-tests-workbench2: #1390

  • All agreed upon points are implemented / addressed.
    • Add bootstrap/coreui for segmented progress bar
    • Upgrade node/node-dom to 16.14 in order to unit test useEffect
    • Place progress bar between subprocess title and headermenu, move multiselect toolbar to below titlebar when there is a panel title or progress bar
    • Add support for multiple statuses combined in segments, onhold displays with queued, cancelled displays with failed
    • Update caniuse and momentjs
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • Added unit tests for progress bar and tested to ensure it creates the correct filters for each segment and correctly combines the right statuses
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • Shouldn't be impacted by scale, the status requests use limit:0 to only retrieve the count of subprocesses with the matching status
  • Considered backwards and forwards compatibility issues between client and server.
    • n/a
  • Follows our coding standards and GUI style guidelines.
    • Space is tight in the title bar so the best I think I can do is tooltips with the status and count
Actions #25

Updated by Peter Amstutz 4 months ago

Stephen Smith wrote in #note-24:

Changes at arvados-workbench2|dcf2e835b33e926073dad1f636cf92a95493ca0b branch 20609-subprocess-progress-bar
Tests developer-tests-workbench2: #1390

  • All agreed upon points are implemented / addressed.
    • Add bootstrap/coreui for segmented progress bar
    • Upgrade node/node-dom to 16.14 in order to unit test useEffect
    • Place progress bar between subprocess title and headermenu, move multiselect toolbar to below titlebar when there is a panel title or progress bar
    • Add support for multiple statuses combined in segments, onhold displays with queued, cancelled displays with failed
    • Update caniuse and momentjs
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • Added unit tests for progress bar and tested to ensure it creates the correct filters for each segment and correctly combines the right statuses
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • Shouldn't be impacted by scale, the status requests use limit:0 to only retrieve the count of subprocesses with the matching status
  • Considered backwards and forwards compatibility issues between client and server.
    • n/a
  • Follows our coding standards and GUI style guidelines.
    • Space is tight in the title bar so the best I think I can do is tooltips with the status and count

Couple thoughts:

  • If you push the bar down by changing the progressWrapper top margin from 25px to 30px, the lower line of the progress bar more or less aligns with the baseline of the title text to the left, which I think looks a bit better than floating vertically not clearly aligned with anything.
  • It's updating the progress bar independently of updating the subprocess listing, which can result in them being out of sync, e.g. the listing is empty but the bar shows several items. It should update both on the same trigger (whether that is polling or websockets).
Actions #26

Updated by Stephen Smith 3 months ago

  • Status changed from In Progress to Resolved
  • Adjusted spacing to line up

Merged in arvados-workbench2|ca46f67ca632f9e1633298ccc5868015acbdd04a

Additional ticket #21206 created for subprocess data explorer not refreshing

Actions

Also available in: Atom PDF