Project

General

Profile

Actions

Feature #20850

closed

Notification that workbench 1 is deprecated

Added by Peter Amstutz 11 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #20867: Review 20850-wb1-deprecatedResolvedPeter Amstutz09/03/2023Actions

Related issues

Related to Arvados - Idea #20932: Workbench 1 loose ends in the documentation to update for Workbench 2ResolvedBrett Smith09/13/2023Actions
Actions #1

Updated by Peter Amstutz 11 months ago

  • Assigned To set to Brett Smith
Actions #2

Updated by Peter Amstutz 11 months ago

  • Release set to 66
Actions #3

Updated by Peter Amstutz 11 months ago

  • Target version changed from Development 2023-08-30 to Development 2023-09-13 sprint
Actions #4

Updated by Peter Amstutz 11 months ago

  • Assigned To changed from Brett Smith to Peter Amstutz
Actions #7

Updated by Peter Amstutz 11 months ago

  • Status changed from New to In Progress
Actions #10

Updated by Peter Amstutz 11 months ago

20850-wb1-deprecated @ ee9d2efeaefb43fa77bdc567ddff0a46d3453a74

developer-run-tests: #3819

[X] Addressed all the points in the story specified, or can explains what changed
[X] Code is tested and passing, both automated and manual
[X] Documentation has been updated.
[n/a] Considered scaling issues, eg when happens when there are 10x - 10000000x more items than tested
[n/a] Considered backwards and forwards compatibility issues between client and server
[n/a] Considered GUI style guidelines

Add a box to the top of every workbench 1 page that tells the user to go to workbench 2. Sends the user to the same URL path as workbench 1 and relies on the wb1->wb2 redirects that were implemented in #20688

Actions #11

Updated by Brett Smith 10 months ago

Peter Amstutz wrote in #note-10:

20850-wb1-deprecated @ ee9d2efeaefb43fa77bdc567ddff0a46d3453a74

All low priority, in order of importance:

  • "workbench" should be capitalized both times it appears in the deprecation notice box text.
  • In both the blocks added to apps/workbench/app/views/layouts/body.html.erb, the indentation is inconsistent. There's both mixed tabs/spaces, and blocks out of alignment even when it's spaces-only.
  • I think the wb2_url block could be simplified down to wb2_url = URI::parse(Rails.configuration.Services.Workbench2.ExternalURL.to_s).merge(request.fullpath).to_s

Do what you want and then go ahead and merge, thanks.

Actions #12

Updated by Peter Amstutz 10 months ago

  • Target version changed from Development 2023-09-13 sprint to Development 2023-09-27 sprint
Actions #13

Updated by Brett Smith 10 months ago

  • Related to Idea #20932: Workbench 1 loose ends in the documentation to update for Workbench 2 added
Actions #14

Updated by Peter Amstutz 10 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF