Project

General

Profile

Actions

Idea #20852

open

Convert cookbook collection recipes into SDK methods

Added by Brett Smith about 1 year ago. Updated about 1 year ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
SDKs
Target version:
Start date:
Due date:
Story points:
-

Description

A lot of code in the Python SDK cookbook that coordinates low-level API calls should just be methods that are defined in the SDK itself. Why force every user to copy-paste these code snippets when we can just give them the method directly?

For recipes that I think are strong candidates for inclusion, here's are some rough sketches of what the method signatures could look like, along with implementation notes.

class Collection:
    def download(self, src: PathLike, dst: PathLike | None=None) -> None: ...
    # If src is a PurePath, generate a manifest path with .as_posix().
    # If dst is None, default to the src basename.

    def upload(self, src: PathLike, dst: PathLike | None=None) -> None: ...
    # Same argument handling as download, except now we use dst.as_posix().

    def iter_files(self, depth: int | None=None) -> Iterator[ArvadosFile]: ...
    # depth limits recursion, None means no limit.

    def iter_streams(self, depth: int | None=None) -> Iterator[Collection]: ...

    def iter_contents(self, depth: int | None=None) -> Iterator[ArvadosFile | Collection]: ...

    def copy(
            self,
            source: PathLike | IO,
            target_path: PathLike | None=None,
            source_collection: Collection | None=None,
            overwrite: bool=False,
    ) -> None: ...
    # Proposed expansion of the existing copy method signature.
    # Explicitly passing an empty target_path should not be required, that can
    # be the default if not specified.
    # If source is an IO, just copy that object directly. target_path defaults
    # to `source.name`. If source_collection is not None, that's a ValueError.
    # If source is an ArvadosFile, can do manifest manipulation directly.
    # If source is PathLike, follows the current implementation.
    # With these changes, the current "copy file" recipe could be simplified to:
    with src_coll.open('ExamplePath') as src_file:
        dst_coll.copy(src_file)

    def sharing_link(self, expires_at: datetime.datetime | datetime.timedelta | None=None) -> str: ...
    # expires_at is used for the created token. If it's a timedelta,
    # that's relative to datetime.datetime.now().
Actions #1

Updated by Brett Smith about 1 year ago

  • Description updated (diff)
Actions #2

Updated by Brett Smith about 1 year ago

  • Description updated (diff)
Actions #3

Updated by Brett Smith about 1 year ago

  • Description updated (diff)
  • Subject changed from Convert cookbook recipes into SDK methods to Convert cookbook collection recipes into SDK methods

Split container methods into #21017.

Actions #4

Updated by Brett Smith about 1 year ago

  • Description updated (diff)
Actions

Also available in: Atom PDF