Arvados

421d6f9ea1 added an explicit dependency on pam to lib/pam/fpm-info.sh. And rocky8's pam package is the one that provides libpam.so.0 (under /usr/lib64 if that matters). And this passed before during review. Soooooo this is weird.

It does succeed sometimes, seemingly at random. Since I added it to build-packages-multijob:

#23 failed at Aug 16, 2023 11:21 PM
#22 failed at Aug 16, 2023 10:01 PM
#21 failed at Aug 16, 2023 9:01 PM
#20 failed at Aug 16, 2023 8:25 PM
#19 succeeded at Aug 16, 2023 1:57 PM
#18 failed at Aug 16, 2023 2:09 AM
#17 failed at Aug 16, 2023 1:07 AM
#16 failed at Aug 15, 2023 11:42 PM
#15 failed at Aug 15, 2023 10:54 PM
#14 failed at Aug 15, 2023 10:15 PM
#13 failed at Aug 15, 2023 9:29 PM
#12 failed at Aug 15, 2023 8:48 PM
#11 failed at Aug 15, 2023 7:35 PM
#10 succeeded at Aug 15, 2023 6:48 PM

A successful build (#10) during the build process:

libpam-arvados-go-2.7.0~dev20230815174158-1.x86_64.rpm not found, building

And then later during the test:

START: libpam-arvados-go test on arvados/package-test:rocky8
…
Package                                             Repository     Size
Installing:                                                            
 cracklib-2.9.6-15.el8.x86_64                       baseos      94.2 kB
 cracklib-dicts-2.9.6-15.el8.x86_64                 baseos       4.1 MB
 libpam-arvados-go-2.7.0~dev20230815174158-1.x86_64 localrepo    6.8 MB
 libpwquality-1.4.4-6.el8.x86_64                    baseos     108.6 kB
 pam-1.3.1-25.el8.x86_64                            baseos     762.8 kB

A failed build (#11) during the build process:

Package libpam-arvados-go-2.7.0~dev20230814202948-1.x86_64.rpm exists upstream, not rebuilding, downloading instead!

And then during tests it only installs libpam-arvados-go, without any dependencies. So there's some difference between these two different build cases that causes the distinction between pass and fail.

The download logic always checks the CentOS 7 repository. So if build-packages-centos7 runs first, those packages upload and then reused for build-packages-rocky8. If it goes the other way, the rocky8 packages build and pass.

The download logic needs to be adapted for the addition of rocky8.

That was a tricky one!! LGTM, thanks.