Arvados

Lucas Di Pentima wrote in #note-12:

Updates at 627f0941a - branch 20889-installer-fixes
Test run: developer-run-tests-doc-and-sdk-R: #1952

• Changes prometheus install source so that it gets installed from archives, avoiding a compatibility issue with grafana on Ubuntu.
• Adds configurable data retention parameter to Prometheus.
• Fixes default values for some environment variables from local.params to avoid script failures.
• Removes DISABLED_CONTROLLER from user-editable local.params to avoid confusion, as the rolling upgrades are performed automatically.
• Updates documentation removing the manual rolling upgrade instructions.
• Adds parameter to handle external database services instead of relying on the DATABASE_INT_IP env var that was also used to set up /etc/hosts entries and failed if not using an IP address.
• Adds configurable parameters for Keep S3 bucket name and IAM profile in local.params.
• Adds configurable parameters for database name and user in local.params.
• Fixes a "unbound variable" bug when using the database and controller roles on the same node (the default multi node deployment configuration)
• Adds checks for certificate file presence when using SSL_MODE=bring-your-own, and updates related documentation.
• Unifies installer.sh indentation because it was a mix of spaces and tabs.
• Adds documentation for the TLS certificate key encryption feature.
• Updates installer's Keep S3 backend documentation.

I have not tried actually running the installer, but looking through the changes, this all LGTM.

Perhaps we should copy the newest installer.sh/provision.sh and salt pillars over to the scale cluster configuration and try that?

Applied changes on the scale-testing repo, commit 977bd92 without errors. Also ran the diagnostics successfully, please double check.

Lucas Di Pentima wrote in #note-17:

Applied changes on the scale-testing repo, commit 977bd92 without errors. Also ran the diagnostics successfully, please double check.

This LGTM, thanks.