Project

General

Profile

Actions

Bug #21002

closed

Restore banner menu item doesn't always work, banner width

Added by Peter Amstutz 8 months ago. Updated 9 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release relationship:
Auto

Description

The "restore banner" menu item sometimes doesn't do anything.

We'd also like to adjust the width so that it has a minimum width (the current size) but the maximum width is a % of the viewport size.


Subtasks 1 (1 open0 closed)

Task #21011: ReviewIn ProgressPeter Amstutz09/28/2023Actions
Actions #1

Updated by Peter Amstutz 8 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz 8 months ago

  • Status changed from In Progress to New
  • Description updated (diff)
  • Subject changed from Restore banner menu item doesn't always work to Restore banner menu item doesn't always work, banner width
Actions #3

Updated by Peter Amstutz 8 months ago

  • Assigned To set to Lisa Knox
Actions #4

Updated by Peter Amstutz 8 months ago

  • Category set to Workbench2
Actions #5

Updated by Lisa Knox 8 months ago

  • Status changed from New to In Progress
Actions #6

Updated by Lisa Knox 8 months ago

developer-tests-workbench2: #1351

  • All agreed upon points are implemented / addressed.
    - done; The intermittent failing of the banner deploy was due to the clickbox in the menu line-item being smaller than was visually indicated by the UI. Moved the onclick to the parent div to fix.
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    - N/A
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    - manually tried to recreate bug several times
  • Documentation has been updated.
    - N/A
  • Behaves appropriately at the intended scale (describe intended scale).
    - tested as a single user
  • Considered backwards and forwards compatibility issues between client and server.
    - N/A
  • Follows our coding standards and GUI style guidelines.
    -done
Actions #7

Updated by Lisa Knox 8 months ago

Also banner width was discussed with Sarah and approved

Actions #8

Updated by Peter Amstutz 7 months ago

This LGTM.

Actions #9

Updated by Anonymous 7 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #10

Updated by Peter Amstutz 9 days ago

  • Release set to 67
Actions

Also available in: Atom PDF