Feature #21036
closedkeep-balance should publish all balancerStats
Description
For some reason keep-balance only publishes a subset of metrics, and interesting numbers like sum(bytes in referenced blocks across all collections) are not published (only indirectly through dedup_byte_ratio).
We should try to publish everything in balancerStats.
Updated by Peter Amstutz about 1 year ago
- Status changed from New to In Progress
Updated by Peter Amstutz about 1 year ago
- Status changed from In Progress to New
- Description updated (diff)
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-10-25 sprint to Development 2023-11-08 sprint
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-11-08 sprint to Development 2023-11-29 sprint
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-11-29 sprint to Development 2024-01-03 sprint
Updated by Peter Amstutz 12 months ago
- Target version changed from Development 2024-01-03 sprint to Development 2024-01-17 sprint
Updated by Tom Clegg 11 months ago
21036-keep-balance-metrics @ 442183cf2d80b50454eb27d09596b8cea5b4303d -- developer-run-tests: #3983
(argh wb2)
Updated by Brett Smith 11 months ago
Tom Clegg wrote in #note-14:
21036-keep-balance-metrics @ 442183cf2d80b50454eb27d09596b8cea5b4303d -- developer-run-tests: #3983
Everything here is good to merge.
Because this story specifies that every balancer stat should be a published metric, I feel like it would be good to have a test for every balancer stat (allowing for presentation differences). This branch moves the ball forward on that, but if I'm following right it looks like there are some balancer stats that are still untested, like lost
and justright
. But that can be a separate ticket if desired.
Updated by Tom Clegg 11 months ago
Fair point.
21036-keep-balance-metrics @ 9ed2609da866201e0353863e5968966fab75e3a4 -- developer-run-tests: #3988
Tests all the balancerStats.
Updated by Brett Smith 11 months ago
Tom Clegg wrote in #note-16:
21036-keep-balance-metrics @ 9ed2609da866201e0353863e5968966fab75e3a4 -- developer-run-tests: #3988
Tests all the balancerStats.
Awesome, thank you, lgtm.
Updated by Tom Clegg 11 months ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados|8e7e7f4a4972c44f2f4a4692953bfbe35ebcdf84.