Project

General

Profile

Actions

Feature #21036

closed

keep-balance should publish all balancerStats

Added by Peter Amstutz 8 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Story points:
1.0
Release relationship:
Auto

Description

For some reason keep-balance only publishes a subset of metrics, and interesting numbers like sum(bytes in referenced blocks across all collections) are not published (only indirectly through dedup_byte_ratio).

We should try to publish everything in balancerStats.


Subtasks 1 (0 open1 closed)

Task #21346: Review 21036-keep-balance-metricsResolvedTom Clegg01/05/2024Actions
Actions #1

Updated by Peter Amstutz 8 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz 8 months ago

  • Status changed from In Progress to New
  • Description updated (diff)
Actions #3

Updated by Peter Amstutz 8 months ago

  • Target version changed from Development 2023-10-25 sprint to Development 2023-11-08 sprint
Actions #4

Updated by Peter Amstutz 7 months ago

  • Description updated (diff)
Actions #5

Updated by Peter Amstutz 7 months ago

  • Description updated (diff)
Actions #6

Updated by Peter Amstutz 7 months ago

  • Story points set to 1.0
Actions #7

Updated by Peter Amstutz 7 months ago

  • Target version changed from Development 2023-11-08 sprint to Development 2023-11-29 sprint
Actions #8

Updated by Peter Amstutz 7 months ago

  • Target version changed from Development 2023-11-29 sprint to Development 2024-01-03 sprint
Actions #9

Updated by Peter Amstutz 6 months ago

  • Category set to Keep
Actions #10

Updated by Peter Amstutz 6 months ago

  • Tracker changed from Bug to Feature
Actions #11

Updated by Peter Amstutz 6 months ago

  • Target version changed from Development 2024-01-03 sprint to Development 2024-01-17 sprint
Actions #12

Updated by Peter Amstutz 5 months ago

  • Assigned To set to Tom Clegg
Actions #13

Updated by Tom Clegg 5 months ago

  • Status changed from New to In Progress
Actions #14

Updated by Tom Clegg 5 months ago

Actions #15

Updated by Brett Smith 5 months ago

Tom Clegg wrote in #note-14:

21036-keep-balance-metrics @ 442183cf2d80b50454eb27d09596b8cea5b4303d -- developer-run-tests: #3983

Everything here is good to merge.

Because this story specifies that every balancer stat should be a published metric, I feel like it would be good to have a test for every balancer stat (allowing for presentation differences). This branch moves the ball forward on that, but if I'm following right it looks like there are some balancer stats that are still untested, like lost and justright. But that can be a separate ticket if desired.

Actions #16

Updated by Tom Clegg 5 months ago

Fair point.

21036-keep-balance-metrics @ 9ed2609da866201e0353863e5968966fab75e3a4 -- developer-run-tests: #3988

Tests all the balancerStats.

Actions #17

Updated by Brett Smith 5 months ago

Tom Clegg wrote in #note-16:

21036-keep-balance-metrics @ 9ed2609da866201e0353863e5968966fab75e3a4 -- developer-run-tests: #3988

Tests all the balancerStats.

Awesome, thank you, lgtm.

Actions #18

Updated by Tom Clegg 5 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #19

Updated by Peter Amstutz 4 months ago

  • Release set to 69
Actions

Also available in: Atom PDF