Project

General

Profile

Actions

Bug #21067

closed

Process panel needs to handle trashed/deleted output and log collections properly

Added by Peter Amstutz 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release relationship:
Auto

Description

If the user opens a process panel and the output collection has been trashed or deleted, it currently throws up a non-specific "Not found" error dialog.

The process panel should be able to handle the situation where the output collection or log are unavailable without raising errors anyway, it should just say "Output not available" or "log not available" where appropriate

Also something to look it to:

  • I suspect the dialog is a generic response to catching a 404 error. Consider using snackbar instead.
  • It doesn't tell you what wasn't found. It should try to provide a bit more information if possible, such as the URL path.

Nice to have:

  • In the case where the output or log is trashed but not yet deleted, we could detect that and provide a way to un-trash it. For example, if #19080 is implemented, this can be as simple as linking to the collection page, which would then present a dialog offered to un-trash the collection.

Subtasks 1 (0 open1 closed)

Task #21153: Review 21067-process-panel-errorResolvedStephen Smith10/26/2023Actions

Related issues

Related to Arvados - Feature #19080: When item is in trash, offer to remove it from trashNewActions
Actions #1

Updated by Peter Amstutz 5 months ago

  • Related to Feature #19080: When item is in trash, offer to remove it from trash added
Actions #2

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2023-11-08 sprint to Development 2023-10-25 sprint
Actions #5

Updated by Peter Amstutz 5 months ago

  • Assigned To set to Stephen Smith
  • Subject changed from Process panel needs to handled trashed/deleted output and log collections properly to Process panel needs to handle trashed/deleted output and log collections properly
Actions #6

Updated by Peter Amstutz 5 months ago

  • Release set to 67
Actions #7

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2023-10-25 sprint to Development 2023-11-08 sprint
Actions #8

Updated by Peter Amstutz 4 months ago

  • Description updated (diff)
Actions #9

Updated by Peter Amstutz 4 months ago

  • Description updated (diff)
Actions #10

Updated by Peter Amstutz 4 months ago

  • Assigned To changed from Stephen Smith to Peter Amstutz
Actions #11

Updated by Peter Amstutz 4 months ago

  • Status changed from New to In Progress
Actions #12

Updated by Peter Amstutz 4 months ago

21067-process-panel-error @ arvados-workbench2|e11c6c520d8d01397f58a5cda1fe7e5e5e06acab

Workbench2 is still busted on jenkins

  • All agreed upon points are implemented / addressed.
    • No longer pops up a dialog when visiting a project where the log or output is missing. Snackbar warnings are shown to notify the user.
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • Didn't do anything about trashed items that could be recovered.
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • manually tested on a process page with the output and log collections trashed.
    • also tested going to non-existent collection, project, workflow pages (see below)
    • whoops, integration tests are failing. It's failing the same way on main so it looks like the workbench 2 build continues to be broken.
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • n/a
  • Considered backwards and forwards compatibility issues between client and server.
    • n/a
  • Follows our coding standards and GUI style guidelines.
    • yes

A few other important changes:

  • Similar to the change in #21077, this removes the default error snackbar popups any time a 400 error happens. This reduces user confusion, particularly when "harmless" errors would occur.
  • The collection files component will no longer give an "unhandled rejection" React failure when it can't load the file list (this took forever to track down.)
  • Collections, projects and workflows will now default to a "not found" panel if they fail to load. Previously, collections and workflows would show nothing at all, and projects would show an empty list.
Actions #13

Updated by Stephen Smith 4 months ago

This lgtm!

Actions #16

Updated by Peter Amstutz 4 months ago

21067-process-panel-error @ 5b30fab0552f623a35ff5b89b90dab82dfcee258

  • Fixed a test of the not found view that was failing (correctly).
  • Refactored to a common NotFoundView to make it easier to add in un-trash behavior (#19080) in the future
  • Fixed a bug where it would incorrectly attempt to navigate to the parent when deleting projects from the 'shared with me' view. It seems that the test was passing by accident before, but that the change in "not found" display made the test fail correctly, which enabled me to track down and fix the actual bug.

developer-tests-workbench2: #1384

Actions #17

Updated by Stephen Smith 4 months ago

This lgtm!

Actions #18

Updated by Peter Amstutz 4 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF