Feature #21128
closedDisplay toolbar for currently selected item
Description
If I click to select a row in a data table (e.g. the Project panel) without clicking on the checkbox to the left, or I only have a single item selected, it should still display a toolbar that has all of the items from the right-click context menu.
Files
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-11-08 sprint to Development 2023-11-29 sprint
Updated by Peter Amstutz about 1 year ago
- Status changed from New to In Progress
Updated by Peter Amstutz about 1 year ago
- Target version changed from Development 2023-11-29 sprint to Development 2024-01-03 sprint
Updated by Lisa Knox about 1 year ago
- File 21128passing.png 21128passing.png added
Changes at arvados-workbench2|0650b4496b8c509d35a953ddea6e9774298593f0 branch 21128-toolbar-context-menu
local integration tests pass, see screenshot in lieu of Jenkins report
- All agreed upon points are implemented / addressed.
- done
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- N/A
- Code is tested and passing, both automated and manual, what manual testing was done is described
- Manually checked all functions for all resource types
- Documentation has been updated.
- N/A
- Behaves appropriately at the intended scale (describe intended scale).
- tested as a single user
- Considered backwards and forwards compatibility issues between client and server.
- Asynchronous actions cause the relevant button to be disabled until resolved
- Follows our coding standards and GUI style guidelines.
- done
Updated by Stephen Smith about 1 year ago
- I noticed a horizontal scrollbar shows briefly up when the icons are animating in, it would be a little nicer if we could suppress that somehow - either by tweaking the transition properties of the icons and the container to make sure it doesn't overflow for no reason while animating or if it's easier by adding overflow:hidden to an animation-in-progress class
- When clicking on an items name to navigate to it, it also checks the item and shows the toolbar before the navigation happens - I think you could fix that by doing something like event.stopPropagation() or event.preventDefault() on the item name navigation handler - I forget which
- This also applies to the 3 button action menu, the UUID and container UUID and modified by user uuid column copy buttons
- The output uuid and log uuid links don't seem to have this problem when you click them, so you can probably copy the solution from there
- It would be great if you can merge main into your branch to make sure there are no issues merging with the progress bar work - in that branch / now in main I fixed the process page subprocess panel close/maximize/options/search being shifted down instead of in the top right corner of the panel
Updated by Lisa Knox about 1 year ago
Changes at arvados-workbench2|bf6b23800e9eb0cfcd2d07eb03a868a63d7142cd branch 21128-toolbar-context-menu
- horizontal scrollbar fixed. Originally, I thought it was fine because it would indicate to the user that scrolling was possible, but to show it during every transition is unnecessary and shoddy, so it's gone until viewport width requires it.
- other points addressed, merged main into local branch and subprocess panel still works as expected. There is some occlusion that happens at <580-ish px width, but I don't think that's relevant to our users.
Updated by Stephen Smith about 1 year ago
One minor thing left with the horizontal scrolling - I seem to be unable to get it to scroll horizontally anymore when the viewport is smaller. This is around 830 pixels wide and the top bar starts overflowing:
Updated by Anonymous about 1 year ago
- Status changed from In Progress to Resolved
Applied in changeset arvados-workbench2|5c7b87f62d045b50e177f788ecdb907ab5402ad7.