Arvados

developer-tests-workbench2: #1382

21158-wf-page-list @ 651e6f0c4eb492a48df0e56783a970c9391237d4

developer-run-tests: #4023

3 items:

• The process test is failing. If you replace all instances of the string "Inputs" to "Input Parameters" and "Outputs" to "Output Parameters" in the test spec it will pass.

• The history records do not have the rowClick feature to select a row and bring up the multiselect toolbar, meaning you can only bring up that toolbar by clicking the checkbox itself.

• I'm not sure if this is relevant or not, but I would think that historical records would generally be readonly? As of now, one can run an on-hold process or edit it, and while that might be entirely appropriate here, it feels antithetical to the 'history' context to me. There's always the option to copy and re-run a process, anyway, so I don't think there's anything lost by making them readonly.

21158-wf-page-list @ 64ca396eef119278018dceb8ca3b6c51f7debb26

developer-run-tests: #4027

• All agreed upon points are implemented / addressed.
  • yes
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • thoughts on the toolbar #21448, see below
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • tests passed locally and manually looked at the layout with the WGS tutorial workflow
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • uses the same paging behavior as "subprocesses" and "all processes" so it should be work fine even with a history of 1000s
• Considered backwards and forwards compatibility issues between client and server.
  • n/a
• Follows our coding standards and GUI style guidelines.
  • yes. the panels have been increased to max-height 100% and reordered to match #21440

Lisa Knox wrote in #note-13:

3 items:

• The process test is failing. If you replace all instances of the string "Inputs" to "Input Parameters" and "Outputs" to "Output Parameters" in the test spec it will pass.

Fixed.

• The history records do not have the rowClick feature to select a row and bring up the multiselect toolbar, meaning you can only bring up that toolbar by clicking the checkbox itself.

As far as I can tell this is working? It is using same control as the process page "subprocesses" list as well as the "all processes" list, just with a different set of filters applied.

• I'm not sure if this is relevant or not, but I would think that historical records would generally be readonly? As of now, one can run an on-hold process or edit it, and while that might be entirely appropriate here, it feels antithetical to the 'history' context to me. There's always the option to copy and re-run a process, anyway, so I don't think there's anything lost by making them readonly.

I want to revisit the exactly icons that are on the toolbar and menus (and the ordering) which would include rethinking whether "edit" or "move" should be there. I do think being able to "run" or "cancel" makes sense here -- for what it is worth, the inspiration for this particular feature is the Jenkins "Build History" table, which does include options to start and stop runs.

https://dev.arvados.org/issues/21448

As far as I can tell this is working?

• Working for me too, I must have been mistaken?

LGTM