Arvados

This is why we test!

Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: {"ClusterID":"scale","PID":3850430,"SubnetID":"subnet-02a50573cbe563dc6","error":"Unsupported: Your requested instance type (t3.small) is not supported in your requested Availability Zone (us-east-1e). Please retry your request by not specifying an Availability Zone or choosing us-east-1a, us-east-1b, us-east-1c, us-east-1d, us-east-1f.\n\tstatus code: 400, request id: 28287e35-add8-48f4-88ff-002aa682a388","level":"warning","msg":"RunInstances failed, trying next subnet","time":"2023-11-09T17:41:15.241859142Z"}
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: panic: runtime error: index out of range [0] with length 0
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: goroutine 9710 [running]:
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: git.arvados.org/arvados.git/lib/cloud/ec2.(*ec2InstanceSet).Create(0xc000734b40, {{0xc0005e89d4, 0x7}, {0xc0005e89c8, 0x8}, 0x2, 0x80000000, 0xba43b7400, 0x0, 0xba43b7400, ...}, ...)
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: #011/arvados/lib/cloud/ec2/ec2.go:335 +0x1394
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: git.arvados.org/arvados.git/lib/dispatchcloud.instrumentedInstanceSet.Create({{0x21e1a90?, 0xc000734b40?}, 0xc000015390?}, {{0xc0005e89d4, 0x7}, {0xc0005e89c8, 0x8}, 0x2, 0x80000000, 0xba43b7400, ...}, ...)
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: #011/arvados/lib/dispatchcloud/driver.go:164 +0xba
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: git.arvados.org/arvados.git/lib/dispatchcloud.rateLimitedInstanceSet.Create({{0x21e49d0?, 0xc000730be8?}, 0xc00009b2c0?}, {{0xc0005e89d4, 0x7}, {0xc0005e89c8, 0x8}, 0x2, 0x80000000, 0xba43b7400, ...}, ...)
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: #011/arvados/lib/dispatchcloud/driver.go:71 +0xfa
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: git.arvados.org/arvados.git/lib/dispatchcloud.defaultTaggingInstanceSet.Create({{0x21e4a00?, 0xc000730c18?}, 0xc0005c3ef0?}, {{0xc0005e89d4, 0x7}, {0xc0005e89c8, 0x8}, 0x2, 0x80000000, 0xba43b7400, ...}, ...)
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: #011/arvados/lib/dispatchcloud/driver.go:104 +0x295
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: git.arvados.org/arvados.git/lib/dispatchcloud/worker.(*Pool).Create.func1()
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: #011/arvados/lib/dispatchcloud/worker/pool.go:356 +0x456
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: created by git.arvados.org/arvados.git/lib/dispatchcloud/worker.(*Pool).Create
Nov  9 17:41:15 workbench arvados-dispatch-cloud[3850430]: #011/arvados/lib/dispatchcloud/worker/pool.go:347 +0x5be
Nov  9 17:41:15 workbench systemd[1]: arvados-dispatch-cloud.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Nov  9 17:41:15 workbench systemd[1]: arvados-dispatch-cloud.service: Failed with result 'exit-code'.

I committed a 1 line fix

28b83594452b195cc1e8b412bdd3a3bb2a91e2d9

run-tests: #6170

With that fix it the scale cluster worked as expected, so this is resolved.