Bug #21206
closedrequesting_container_uuid missing from websocket events for container request create/updates
Description
The subprocess data explorer relies on websocket event updates in websockets.ts
to let it know when to refresh the data explorer. It compares the requesting_container_uuid
in the new_attributes
with the currently open process page's container.uuid
to see if the data explorer needs to be refreshed.
For some reason, neither create nor update websocket events have requesting_container_uuid
, so the subprocess data explorer never refreshes
Updated by Tom Clegg about 1 year ago
I think the fix is this easy:
21206-ws-requesting-container-uuid @ 1875ec0fead829272cc609f9d1431f4922633d49
Testing will require a bit more effort, though.
Updated by Peter Amstutz about 1 year ago
- Target version set to Development 2024-01-03 sprint
Updated by Peter Amstutz about 1 year ago
Tom Clegg wrote in #note-1:
I think the fix is this easy:
21206-ws-requesting-container-uuid @ 1875ec0fead829272cc609f9d1431f4922633d49
Testing will require a bit more effort, though.
I don't know what we want to do for automated testing, but I've manually checked and this seems to do the trick (output from arv-ws
):
{"event_at": "2023-12-11T14:58:56.051898Z", "event_type": "create", "id": 322024, "msgID": 3, "object_kind": "arvados#containerRequest", "object_owner_uuid": "x94bf-tpzed-jqaqdbt17vkcd2l", "object_uuid": "x94bf-xvhdp-6tk3n99ih0kr99r", "properties": {"new_attributes": {"name": "sorted", "owner_uuid": "x94bf-tpzed-jqaqdbt17vkcd2l", "requesting_container_uuid": "x94bf-dz642-w4tmt7r05640a5z", "state": "Uncommitted"}}, "uuid": "x94bf-57u5n-1pz38sindtk7vol"} {"event_at": "2023-12-11T14:58:56.123618Z", "event_type": "create", "id": 322025, "msgID": 4, "object_kind": "arvados#container", "object_owner_uuid": "x94bf-tpzed-000000000000000", "object_uuid": "x94bf-dz642-tz0t3dhs6jakaeh", "properties": {"new_attributes": {"owner_uuid": "x94bf-tpzed-000000000000000", "state": "Queued"}}, "uuid": "x94bf-57u5n-g18peru6deboypm"}
Updated by Tom Clegg about 1 year ago
- Status changed from New to In Progress
Fix is merged, leaving issue open in hopes of adding a test.
Updated by Tom Clegg 12 months ago
21206-ws-requesting-container-uuid @ 7fdaebf3e915e70403c40a1ce901ca767394a7a2 -- developer-run-tests: #3977
Adds test case.
Updated by Lucas Di Pentima 12 months ago
21206-ws-requesting-container-uuid
LGTM, thanks.
Updated by Tom Clegg 12 months ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados|e508443dd138027cecdf654fb515df910cdeeed8.