Project

General

Profile

Actions

Bug #21206

closed

requesting_container_uuid missing from websocket events for container request create/updates

Added by Stephen Smith about 1 year ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Story points:
-
Release relationship:
Auto

Description

The subprocess data explorer relies on websocket event updates in websockets.ts to let it know when to refresh the data explorer. It compares the requesting_container_uuid in the new_attributes with the currently open process page's container.uuid to see if the data explorer needs to be refreshed.

For some reason, neither create nor update websocket events have requesting_container_uuid, so the subprocess data explorer never refreshes


Subtasks 1 (0 open1 closed)

Task #21232: Review 21206-ws-requesting-container-uuidResolvedTom Clegg12/29/2023Actions
Actions #1

Updated by Tom Clegg about 1 year ago

I think the fix is this easy:

21206-ws-requesting-container-uuid @ 1875ec0fead829272cc609f9d1431f4922633d49

Testing will require a bit more effort, though.

Actions #2

Updated by Peter Amstutz 12 months ago

  • Target version set to Development 2024-01-03 sprint
Actions #3

Updated by Peter Amstutz 12 months ago

  • Assigned To set to Tom Clegg
Actions #4

Updated by Peter Amstutz 12 months ago

  • Release set to 69
Actions #5

Updated by Peter Amstutz 12 months ago

  • Release changed from 69 to 67
Actions #6

Updated by Peter Amstutz 12 months ago

Tom Clegg wrote in #note-1:

I think the fix is this easy:

21206-ws-requesting-container-uuid @ 1875ec0fead829272cc609f9d1431f4922633d49

Testing will require a bit more effort, though.

I don't know what we want to do for automated testing, but I've manually checked and this seems to do the trick (output from arv-ws):

{"event_at": "2023-12-11T14:58:56.051898Z", "event_type": "create", "id": 322024, "msgID": 3, "object_kind": "arvados#containerRequest", "object_owner_uuid": "x94bf-tpzed-jqaqdbt17vkcd2l", "object_uuid": "x94bf-xvhdp-6tk3n99ih0kr99r", "properties": {"new_attributes": {"name": "sorted", "owner_uuid": "x94bf-tpzed-jqaqdbt17vkcd2l", "requesting_container_uuid": "x94bf-dz642-w4tmt7r05640a5z", "state": "Uncommitted"}}, "uuid": "x94bf-57u5n-1pz38sindtk7vol"} {"event_at": "2023-12-11T14:58:56.123618Z", "event_type": "create", "id": 322025, "msgID": 4, "object_kind": "arvados#container", "object_owner_uuid": "x94bf-tpzed-000000000000000", "object_uuid": "x94bf-dz642-tz0t3dhs6jakaeh", "properties": {"new_attributes": {"owner_uuid": "x94bf-tpzed-000000000000000", "state": "Queued"}}, "uuid": "x94bf-57u5n-g18peru6deboypm"}

Actions #7

Updated by Tom Clegg 12 months ago

  • Status changed from New to In Progress

Fix is merged, leaving issue open in hopes of adding a test.

Actions #8

Updated by Tom Clegg 11 months ago

21206-ws-requesting-container-uuid @ 7fdaebf3e915e70403c40a1ce901ca767394a7a2 -- developer-run-tests: #3977

Adds test case.

Actions #9

Updated by Lucas Di Pentima 11 months ago

21206-ws-requesting-container-uuid LGTM, thanks.

Actions #10

Updated by Tom Clegg 11 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF