Project

General

Profile

Actions

Bug #21216

closed

Fix "memoryRetryMultipler" misspelled name

Added by Brett Smith 12 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
CWL
Story points:
0.5
Release relationship:
Auto

Description

This is in our CWL OutOfMemoryRetry extension. "Multipler" is not a word. I don't know whether we meant "Multiple" or "Multiplier".

I don't know what the backwards compatibility story is here, that should be specified before development. But when you're writing code in YAML with little tooling support to catch errors, predictable names go a long way, so I think this is worth fixing somehow.


Subtasks 1 (0 open1 closed)

Task #21344: Review 21216-multiplier-typo-fix ResolvedPeter Amstutz01/09/2024Actions
Actions #1

Updated by Peter Amstutz 12 months ago

That's embarrassing. Yes, that was supposed to be "Multiplier".

We can fix it to accept both (the misspelled value and the new one) and have the documentation tell people to use the correct spelling.

Actions #2

Updated by Peter Amstutz 11 months ago

  • Target version changed from Future to Development 2024-01-17 sprint
Actions #3

Updated by Peter Amstutz 11 months ago

  • Story points set to 0.5
Actions #4

Updated by Peter Amstutz 11 months ago

  • Assigned To set to Peter Amstutz
Actions #6

Updated by Peter Amstutz 11 months ago

21216-multiplier-typo-fix @ 999ef5f71d522283465b54b6468bae6badf28ca4

developer-run-tests: #3991

  • All agreed upon points are implemented / addressed.
    • yes
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • yes, updated the tests with the new, fixed spelling and added a regression test with the old spelling
  • Documentation has been updated.
    • yes, only lists the new spelling
  • Behaves appropriately at the intended scale (describe intended scale).
    • n/a
  • Considered backwards and forwards compatibility issues between client and server.
    • accepts both spellings, with the correct spelling taking precedence
  • Follows our coding standards and GUI style guidelines.
    • yes
Actions #7

Updated by Peter Amstutz 10 months ago

No changes, just rebased on main:

21216-multiplier-typo-fix @ 5c2f3f465ac10b674e9033083063489a2d9b73c2

developer-run-tests: #3993

Actions #8

Updated by Peter Amstutz 10 months ago

  • Status changed from New to In Progress
Actions #9

Updated by Peter Amstutz 10 months ago

  • Target version changed from Development 2024-01-17 sprint to Development 2024-01-31 sprint
Actions #10

Updated by Peter Amstutz 10 months ago

  • Target version changed from Development 2024-01-31 sprint to Development 2024-02-14 sprint
Actions #11

Updated by Peter Amstutz 10 months ago

  • Release set to 69
Actions #12

Updated by Alex Coleman 10 months ago

LGTM.

Actions #13

Updated by Peter Amstutz 10 months ago

  • Status changed from In Progress to Resolved
Actions #14

Updated by Peter Amstutz 8 months ago

  • Tracker changed from Idea to Bug
Actions

Also available in: Atom PDF