Bug #21216: Fix "memoryRetryMultipler" misspelled name - Arvados

Actions

Copy link

Bug #21216

closed

Fix "memoryRetryMultipler" misspelled name

Added by Brett Smith 6 months ago. Updated about 2 months ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Peter Amstutz

Category:

CWL

Target version:

Development 2024-02-14 sprint

Story points:

0.5

Release:

Arvados 2.7.2

Release relationship:

Auto

Description

This is in our CWL OutOfMemoryRetry extension. "Multipler" is not a word. I don't know whether we meant "Multiple" or "Multiplier".

I don't know what the backwards compatibility story is here, that should be specified before development. But when you're writing code in YAML with little tooling support to catch errors, predictable names go a long way, so I think this is worth fixing somehow.

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Peter Amstutz 5 months ago

That's embarrassing. Yes, that was supposed to be "Multiplier".

We can fix it to accept both (the misspelled value and the new one) and have the documentation tell people to use the correct spelling.

Actions

Copy link

Updated by Peter Amstutz 5 months ago

Target version changed from Future to Development 2024-01-17 sprint

Actions

Copy link

Updated by Peter Amstutz 5 months ago

Story points set to 0.5

Actions

Copy link

Updated by Peter Amstutz 4 months ago

Assigned To set to Peter Amstutz

Actions

Copy link

Updated by Peter Amstutz 4 months ago

21216-multiplier-typo-fix @ 798a896a1a5f411d0d9675a513e1ddeccc3c818d

developer-run-tests: #3989

Actions

Copy link

Updated by Peter Amstutz 4 months ago

21216-multiplier-typo-fix @ 999ef5f71d522283465b54b6468bae6badf28ca4

developer-run-tests: #3991

All agreed upon points are implemented / addressed.
- yes
Anything not implemented (discovered or discussed during work) has a follow-up story.
- n/a
Code is tested and passing, both automated and manual, what manual testing was done is described
- yes, updated the tests with the new, fixed spelling and added a regression test with the old spelling
Documentation has been updated.
- yes, only lists the new spelling
Behaves appropriately at the intended scale (describe intended scale).
- n/a
Considered backwards and forwards compatibility issues between client and server.
- accepts both spellings, with the correct spelling taking precedence
Follows our coding standards and GUI style guidelines.
- yes