Arvados

Changes at arvados|75017b1e056df82d947db19a024c524072d0d55d
Tests developer-run-tests-services-workbench2: #518

• All agreed upon points are implemented / addressed.
  • Changed groups middleware to request count of each group's members
  • Count is now stored in the resource store on a local property memberCount, which is absent/undefined initially and null if the request failed
  • Added a loading indicator pulser that shows while the limit=0 list request is loading, if the request fails a grey error icon shows with a tooltip saying that the count failed to load
• Added unit tests to verify that the middleware requests count and stores it on the resource, as well as stores null if the request failed
  • Added unit test to verify loading pulser, error icon, and correct count on the GroupMembersCount renderer
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • Added unit tests for everything
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • Only 1 request per group on the current data explorer page
• Considered backwards and forwards compatibility issues between client and server.
  • n/a
• Follows our coding standards and GUI style guidelines.
  • Yes

This all LGTM, but the inline loading pulser is something I haven't seen anywhere else on WB2 (usually it's an entire table replaced by the loading view, not a single item) so it looks out of place to me, even though it looks good in and of itself. It would be nice to use this same pulser elsewhere going forward (where applicable) to foster some visual consistency across WB2.