Project

General

Profile

Actions

Feature #21224

open

Project details panel

Added by Peter Amstutz 5 months ago. Updated 2 days ago.

Status:
In Progress
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-


Files

Screenshot-description.png (35.1 KB) Screenshot-description.png Peter Amstutz, 02/13/2024 03:02 PM
Screenshot-user-menu.png (20.7 KB) Screenshot-user-menu.png Peter Amstutz, 02/13/2024 03:05 PM
Screenshot-tidy-group.png (15.3 KB) Screenshot-tidy-group.png Peter Amstutz, 02/13/2024 03:22 PM
Screenshot-no-prop-no-desc.png (13.1 KB) Screenshot-no-prop-no-desc.png Peter Amstutz, 02/13/2024 03:30 PM
user-project-missing-i.png (43 KB) user-project-missing-i.png Peter Amstutz, 04/25/2024 08:43 PM
bananaprj.png (14.4 KB) bananaprj.png Peter Amstutz, 04/25/2024 08:50 PM
this-project-is.png (19.3 KB) this-project-is.png Peter Amstutz, 04/25/2024 08:51 PM
project-details.png (32.2 KB) project-details.png Peter Amstutz, 04/25/2024 08:57 PM

Subtasks 1 (1 open0 closed)

Task #21239: Review 21224-project-detailsIn ProgressLisa Knox04/25/2024Actions

Related issues

Related to Arvados Epics - Idea #16943: WB2 Descriptions, project & collection operationsIn Progress10/01/202206/30/2024Actions
Related to Arvados - Idea #21509: Details not available for home projectNewLisa KnoxActions
Actions #1

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 5 months ago

  • Assigned To set to Lisa Knox
Actions #3

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2024-01-03 sprint to Development 2024-01-17 sprint
Actions #4

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2024-01-17 sprint to Development 2024-01-31 sprint
Actions #5

Updated by Lisa Knox 3 months ago

Actions #6

Updated by Lisa Knox 3 months ago

  • Status changed from New to In Progress
Actions #7

Updated by Peter Amstutz 3 months ago

  • Related to Idea #16943: WB2 Descriptions, project & collection operations added
Actions #8

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-01-31 sprint to Development 2024-02-14 sprint
Actions #9

Updated by Lisa Knox 3 months ago

developer-run-tests-services-workbench2: #467

21224-project-details @ a60e439fc82ee7e866b3d15c62fe5b3760894ff4

  • ✅ All agreed upon points are implemented / addressed.
  • ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
  • ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
  • ✅ Documentation has been updated.
    • n/a
  • ✅ Behaves appropriately at the intended scale (describe intended scale).
  • ✅ Considered backwards and forwards compatibility issues between client and server.
    • n/a
  • ✅ Follows our coding standards and GUI style guidelines.
Notes:
  • I opted for an outline to highlight the details card (when parent project is displayed in the details panel) instead of the light grey which was either unnoticeable or too dark imo.
Actions #10

Updated by Peter Amstutz 2 months ago

Lisa Knox wrote in #note-9:

developer-run-tests-services-workbench2: #467

21224-project-details @ a60e439fc82ee7e866b3d15c62fe5b3760894ff4

  • ✅ All agreed upon points are implemented / addressed.
  • ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
  • ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
  • ✅ Documentation has been updated.
    • n/a
  • ✅ Behaves appropriately at the intended scale (describe intended scale).
  • ✅ Considered backwards and forwards compatibility issues between client and server.
    • n/a
  • ✅ Follows our coding standards and GUI style guidelines.
Notes:
  • I opted for an outline to highlight the details card (when parent project is displayed in the details panel) instead of the light grey which was either unnoticeable or too dark imo.

Isn't this supposed to show the first line or sentence of the description? Also, if the full description is visible, there is not reason to have a "show full description" button. Also I thought we were going to do a down arrow or chevron to indicate it could be expanded, instead of a link?

Can we reduce the top/bottom padding on the title and description to try to shorten the box a bit?

I was really confused about what the "Project" option did, until I realized this menu was copied from the user profile view. We should (a) rename it to "Home project" and (b) don't show that menu option when we're already viewing the home project.

I would get rid of "deactivate user" from this menu as well, since we can navigate to the account settings. And rename "account settings" to "user account" or "user profile".

The description HTML should have been sanitized (we did this already in redux) so it should be rendered here.

Let's shrink the whitespace around the properties a bit.

There is a huge amount of whitespace here for no properties and no description, how can we shrink that?

Actions #11

Updated by Peter Amstutz 2 months ago

From discussion:

The properties and and description lines should have a max-height, with a toggle arrow on the left that expands them to full height.

Actions #12

Updated by Peter Amstutz 2 months ago

  • Target version changed from Development 2024-02-14 sprint to Development 2024-02-28 sprint
Actions #13

Updated by Peter Amstutz 2 months ago

  • Related to Idea #21509: Details not available for home project added
Actions #14

Updated by Lisa Knox 2 months ago

The following commits from #21386 were improperly attributed to ticket #21224 :

  • c6215a9818ef18c35df66488e0d80074b0631a34
  • 9aefffe7db795c8b4aacfc8c2dbfc2eab17ad363
  • 0bbc879707665f316892387570182d1d2209e91c
  • fe65b9e7f45f69ccd9c73ca6cf220cd544512d0a
  • a8915904f23325c5c6e465164bc032e0dabc4229
Actions #15

Updated by Peter Amstutz about 2 months ago

  • Target version changed from Development 2024-02-28 sprint to Development 2024-03-13 sprint
Actions #16

Updated by Peter Amstutz about 2 months ago

  • Target version changed from Development 2024-03-13 sprint to Development 2024-03-27 sprint
Actions #17

Updated by Peter Amstutz about 1 month ago

  • Target version changed from Development 2024-03-27 sprint to Development 2024-04-10 sprint
Actions #18

Updated by Peter Amstutz 18 days ago

  • Target version changed from Development 2024-04-10 sprint to Development 2024-04-24 sprint
Actions #19

Updated by Peter Amstutz 4 days ago

  • Target version changed from Development 2024-04-24 sprint to Development 2024-05-08 sprint
Actions #20

Updated by Lisa Knox 3 days ago

developer-run-tests-services-workbench2: #769

21224-project-details@da46b2d068f86e75d055f98acbdbb789a4a7712f

Isn't this supposed to show the first line or sentence of the description?

fixed

Can we reduce the top/bottom padding on the title and description to try to shorten the box a bit?

fixed, and reduced overall whitespace in general

I was really confused about what the "Project" option did, until I realized this menu was copied from the user profile view. We should (a) rename it to "Home project" and (b) don't show that menu option when we're already viewing the home project.

I would get rid of "deactivate user" from this menu as well, since we can navigate to the account settings. And rename "account settings" to "user account" or "user profile".

done and done

The description HTML should have been sanitized (we did this already in redux) so it should be rendered here.

fixed

Notes:
  • I handled #21509 while doing this, but that will likely be overwritten in #21615
  • There is now a single global `selectedResourceUuid` which is used to populate the details panel and to determine which resource has context for the multiselect toolbar. This will likely be useful in #21615 as well. The details card itself uses the URL UUID to determine what to show.
Actions #21

Updated by Peter Amstutz 2 days ago

Home project of another user

When looking at a home project of another user, it needs the (i) icon

Can we also change the order of the toolbar looking at a user home project to

  1. info
  2. user account
  3. API details

"attributes" is redundant and should be removed, the information it has should all be available on user account or API details views.

Regular project

Is it possible to limit rendering the left chevron for description/properties to situations where it actually needs to be expanded to show everything?

For some reason the toolbar is smushed over to the right (actually, glancing at the CSS it seems the toolbar is limited to 39.5rem width), so most of the buttons are in the overflow menu.

Also, the description is

  1. cut off, when it could easily fit on one line
  2. not rendering bold and italics, this is what it is supposed to look like

Right side project details

Let's re-order project details to:

  • Type
  • UUID
  • Owner
  • Created at
  • Last modified
  • Last modified by user (modified_by_user_uuid field)
  • Description
  • Properties
Actions

Also available in: Atom PDF