Lisa Knox wrote in #note-9:

developer-run-tests-services-workbench2: #467

21224-project-details @ a60e439fc82ee7e866b3d15c62fe5b3760894ff4

• ✅ All agreed upon points are implemented / addressed.
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
  • https://dev.arvados.org/issues/21412
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
• ✅ Documentation has been updated.
  • n/a
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
  • n/a
• ✅ Follows our coding standards and GUI style guidelines.

Notes:

• I opted for an outline to highlight the details card (when parent project is displayed in the details panel) instead of the light grey which was either unnoticeable or too dark imo.

Isn't this supposed to show the first line or sentence of the description? Also, if the full description is visible, there is not reason to have a "show full description" button. Also I thought we were going to do a down arrow or chevron to indicate it could be expanded, instead of a link?

Can we reduce the top/bottom padding on the title and description to try to shorten the box a bit?

I was really confused about what the "Project" option did, until I realized this menu was copied from the user profile view. We should (a) rename it to "Home project" and (b) don't show that menu option when we're already viewing the home project.

I would get rid of "deactivate user" from this menu as well, since we can navigate to the account settings. And rename "account settings" to "user account" or "user profile".

The description HTML should have been sanitized (we did this already in redux) so it should be rendered here.

Let's shrink the whitespace around the properties a bit.

There is a huge amount of whitespace here for no properties and no description, how can we shrink that?

Home project of another user¶

When looking at a home project of another user, it needs the (i) icon

Can we also change the order of the toolbar looking at a user home project to

1. info
2. user account
3. API details

"attributes" is redundant and should be removed, the information it has should all be available on user account or API details views.

Regular project¶

Is it possible to limit rendering the left chevron for description/properties to situations where it actually needs to be expanded to show everything?

For some reason the toolbar is smushed over to the right (actually, glancing at the CSS it seems the toolbar is limited to 39.5rem width), so most of the buttons are in the overflow menu.

Also, the description is

1. cut off, when it could easily fit on one line
2. not rendering bold and italics, this is what it is supposed to look like

Right side project details¶

Let's re-order project details to:

• Type
• UUID
• Owner
• Created at
• Last modified
• Last modified by user (modified_by_user_uuid field)
• Description
• Properties

I'm still getting the issue with the description wrapping prematurely. I'm using Firefox.

It seems that removing 'width' entirely may fix it?

Everything else looks good!

Lisa Knox wrote in #note-26:

developer-run-tests-services-workbench2: #867

I'm still not able to replicate the width display bug locally, and have tried different browsers trying to do so. I removed the width property and I also noticed a small UI bug (the height of the card would change when toggling the description even when the description was only one line), which I fixed and then added a test for.

The description is formatting correctly now, thank you.

I am super happy with this, I think people are really going to like it.

I only found one small graphical glitch. With some combinations of growing/shrinking the window the "More Options" chevron can get cut off a bit. However, if it takes more than a couple minutes to fix, I'd prefer you merged as is than endlessly tinker with it any more.

LGTM!!!

Applied in changeset arvados|89fc1810ba39a7a0aebccba690c7bc663bca8c0b.