Project

General

Profile

Actions

Bug #21315

closed

Row select should deslect all other rows

Added by Lisa Knox 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release relationship:
Auto

Description

In the data explorer, when selecting a row, it should highlight the row, check the checkbox, deselect all other checkboxes, and load the details for that row item into the details panel. The checkboxes should have a slightly larger clickbox than is visually indicated to avoid misclicks.


Subtasks 1 (0 open1 closed)

Task #21338: ReviewResolvedPeter Amstutz01/08/2024Actions
Actions #1

Updated by Peter Amstutz 5 months ago

  • Target version set to Development 2024-01-17 sprint
  • Category set to Workbench2
Actions #2

Updated by Brett Smith 4 months ago

I think this story makes sense. This behavior is analogous with a lot of other tools, including our main inspiration Google Drive.

However, it always sucks when you're trying to de/select a bunch of items based on arbitrary criteria, and you accidentally miss your target (the checkbox) once, open an item, and lose all your de/selection work.

One nice affordance in GMail is the checkbox target is much larger than the checkbox itself, and there's a halo effect around the checkbox whenever you're hovering over the toggle target. We have a nice large checkbox target, but I doubt users know that because there's nothing like the halo effect to let them know. (I didn't know until I intentionally tested it while writing this.) Would it be much trouble to add a similar effect as part of this story? If yes, could we have a separate story?

Actions #3

Updated by Lisa Knox 4 months ago

  • Description updated (diff)
Actions #4

Updated by Lisa Knox 4 months ago

The larger clickbox was mentioned in the discussion and should have been added to the initial description.

Actions #5

Updated by Lisa Knox 4 months ago

21315-row-select @ 846d1322282be39bd2db362c7f97a4068a3e1867
developer-run-tests-services-workbench2: #132

  • ✅ All agreed upon points are implemented / addressed.
  • ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
  • ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
  • ✅ Documentation has been updated.
  • ✅ Behaves appropriately at the intended scale (describe intended scale).
  • ✅ Considered backwards and forwards compatibility issues between client and server.
  • ✅ Follows our coding standards and GUI style guidelines.
Notes:
  • I settled on a hitbox ~4px larger than the checkbox itself, which looks fine to me but is obviously debatable. The cursor changes to a finger on hover.
  • I decided against the hover-halo effect that Brett suggested because the row already has a hover effect, so adding a second wouldn't look good. That said, I'm not sure how useful the row hover is, so we can swap one hover for another if we want.
Actions #6

Updated by Peter Amstutz 4 months ago

Lisa Knox wrote in #note-5:

21315-row-select @ 846d1322282be39bd2db362c7f97a4068a3e1867
developer-run-tests-services-workbench2: #132

  • ✅ All agreed upon points are implemented / addressed.
  • ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
  • ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
  • ✅ Documentation has been updated.
  • ✅ Behaves appropriately at the intended scale (describe intended scale).
  • ✅ Considered backwards and forwards compatibility issues between client and server.
  • ✅ Follows our coding standards and GUI style guidelines.
Notes:
  • I settled on a hitbox ~4px larger than the checkbox itself, which looks fine to me but is obviously debatable. The cursor changes to a finger on hover.
  • I decided against the hover-halo effect that Brett suggested because the row already has a hover effect, so adding a second wouldn't look good. That said, I'm not sure how useful the row hover is, so we can swap one hover for another if we want.

I think the extended hitbox could be bigger, maybe 8px?

Otherwise, this LGTM.

Actions #7

Updated by Peter Amstutz 4 months ago

  • Status changed from New to In Progress
Actions #8

Updated by Lisa Knox 4 months ago

8px it is!

Actions #9

Updated by Anonymous 4 months ago

  • Status changed from In Progress to Resolved
Actions #10

Updated by Peter Amstutz 3 months ago

  • Release set to 69
Actions

Also available in: Atom PDF