Bug #21315
closedRow select should deslect all other rows
Description
In the data explorer, when selecting a row, it should highlight the row, check the checkbox, deselect all other checkboxes, and load the details for that row item into the details panel. The checkboxes should have a slightly larger clickbox than is visually indicated to avoid misclicks.
Updated by Peter Amstutz 11 months ago
- Target version set to Development 2024-01-17 sprint
- Category set to Workbench2
Updated by Brett Smith 11 months ago
I think this story makes sense. This behavior is analogous with a lot of other tools, including our main inspiration Google Drive.
However, it always sucks when you're trying to de/select a bunch of items based on arbitrary criteria, and you accidentally miss your target (the checkbox) once, open an item, and lose all your de/selection work.
One nice affordance in GMail is the checkbox target is much larger than the checkbox itself, and there's a halo effect around the checkbox whenever you're hovering over the toggle target. We have a nice large checkbox target, but I doubt users know that because there's nothing like the halo effect to let them know. (I didn't know until I intentionally tested it while writing this.) Would it be much trouble to add a similar effect as part of this story? If yes, could we have a separate story?
Updated by Lisa Knox 11 months ago
21315-row-select @ 846d1322282be39bd2db362c7f97a4068a3e1867
developer-run-tests-services-workbench2: #132
- ✅ All agreed upon points are implemented / addressed.
- ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
- ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
- ✅ Documentation has been updated.
- ✅ Behaves appropriately at the intended scale (describe intended scale).
- ✅ Considered backwards and forwards compatibility issues between client and server.
- ✅ Follows our coding standards and GUI style guidelines.
- I settled on a hitbox ~4px larger than the checkbox itself, which looks fine to me but is obviously debatable. The cursor changes to a finger on hover.
- I decided against the hover-halo effect that Brett suggested because the row already has a hover effect, so adding a second wouldn't look good. That said, I'm not sure how useful the row hover is, so we can swap one hover for another if we want.
Updated by Peter Amstutz 11 months ago
Lisa Knox wrote in #note-5:
21315-row-select @ 846d1322282be39bd2db362c7f97a4068a3e1867
developer-run-tests-services-workbench2: #132Notes:
- ✅ All agreed upon points are implemented / addressed.
- ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
- ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
- ✅ Documentation has been updated.
- ✅ Behaves appropriately at the intended scale (describe intended scale).
- ✅ Considered backwards and forwards compatibility issues between client and server.
- ✅ Follows our coding standards and GUI style guidelines.
- I settled on a hitbox ~4px larger than the checkbox itself, which looks fine to me but is obviously debatable. The cursor changes to a finger on hover.
- I decided against the hover-halo effect that Brett suggested because the row already has a hover effect, so adding a second wouldn't look good. That said, I'm not sure how useful the row hover is, so we can swap one hover for another if we want.
I think the extended hitbox could be bigger, maybe 8px?
Otherwise, this LGTM.
Updated by Anonymous 10 months ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|f9ae14ce8c4d749cfdc007ec45929cc9a09a3790.