Project

General

Profile

Actions

Bug #21316

closed

left panel collapse issues

Added by Lisa Knox 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release relationship:
Auto

Description

  • It is possible to make the side panel collapsed without switching to the collapsed sidepanel component. It happens when the viewport is less than a certain width, then have the side panel open and then trigger the details panel.
  • The collapsed side panel resizes when the details panel is opened and looks janky

Subtasks 1 (0 open1 closed)

Task #21339: Review 21316-left-panel-collapseResolvedPeter Amstutz01/05/2024Actions
Actions #1

Updated by Peter Amstutz 5 months ago

  • Target version set to Development 2024-01-17 sprint
Actions #2

Updated by Peter Amstutz 5 months ago

  • Category set to Workbench2
Actions #3

Updated by Lisa Knox 4 months ago

developer-run-tests-services-workbench2: #129

It is possible to make the side panel collapsed without switching to the collapsed sidepanel component. It happens when the viewport is less than a certain width, then have the side panel open and then trigger the details panel.

The collapsed side panel resizes when the details panel is opened and looks janky

  • Fixed the second issue by making it so the panel splitter doesn't move at all when side panel is collapsed. This allowed me to remove an excess `applyCollapsedState()` call, which was the source of the first issue.
Actions #4

Updated by Lisa Knox 4 months ago

commit fabc97343f1b74c66890c00295c5c1911d5e096a on branch 21316-left-panel-collapse

  • All agreed upon points are implemented / addressed.
    • done
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • N/A
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • couldn't replicate the issues after the fix
  • Documentation has been updated.
    • N/A
  • Behaves appropriately at the intended scale (describe intended scale).
    • tested as a single user
  • Considered backwards and forwards compatibility issues between client and server.
    • N/A
  • Follows our coding standards and GUI style guidelines.
    • done
Actions #5

Updated by Peter Amstutz 4 months ago

Lisa Knox wrote in #note-4:

commit fabc97343f1b74c66890c00295c5c1911d5e096a on branch 21316-left-panel-collapse

  • All agreed upon points are implemented / addressed.
    • done
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • N/A
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • couldn't replicate the issues after the fix
  • Documentation has been updated.
    • N/A
  • Behaves appropriately at the intended scale (describe intended scale).
    • tested as a single user
  • Considered backwards and forwards compatibility issues between client and server.
    • N/A
  • Follows our coding standards and GUI style guidelines.
    • done

I played with it and didn't see the previous buggy behavior, this LGTM.

Actions #6

Updated by Peter Amstutz 4 months ago

  • Status changed from New to In Progress
Actions #7

Updated by Anonymous 4 months ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Peter Amstutz 3 months ago

  • Release set to 69
Actions

Also available in: Atom PDF